New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4797982: Setting negative size of JSplitPane divider leads to unexpected results. #9566
Closed
Closed
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5f50042
4797982: Setting negative size of JSplitPane divider leads to unexpec…
prsadhuk de6badd
4797982: Setting negative size of JSplitPane divider leads to unexpec…
prsadhuk 40ddca9
Fix
prsadhuk 758dfb8
Fix to return L&F specific divider size
prsadhuk a5a9ec8
Clarify behavior in javadoc
prsadhuk b486ea4
Fix
prsadhuk beb1f57
Javadoc correction
prsadhuk ec9429a
Remove implNote tag
prsadhuk e876ddb
Do not ignore 0 divider size
prsadhuk File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
test/jdk/javax/swing/JSplitPane/JSplitPaneTestNegDivSize.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
/* | ||
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/* @test | ||
* @key headful | ||
* @bug 4797982 | ||
* @summary Verifies if negative size of JSplitPane divider can be set. | ||
* @run main JSplitPaneTestNegDivSize | ||
*/ | ||
import java.awt.BorderLayout; | ||
import java.awt.Dimension; | ||
import javax.swing.JFrame; | ||
import javax.swing.JSplitPane; | ||
import javax.swing.JTextArea; | ||
import javax.swing.SwingUtilities; | ||
import javax.swing.UIManager; | ||
import javax.swing.plaf.basic.BasicSplitPaneUI; | ||
|
||
public class JSplitPaneTestNegDivSize { | ||
|
||
private static volatile int divSize; | ||
private static volatile int basicDivSize; | ||
private static JFrame frame; | ||
private static JSplitPane sp; | ||
|
||
public static void main(String[] args) throws Exception { | ||
SwingUtilities.invokeAndWait(() -> { | ||
frame = new JFrame(); | ||
sp = new JSplitPane(JSplitPane.VERTICAL_SPLIT, true, | ||
new JTextArea("I am top text area!"), | ||
new JTextArea("I am bottom text area!")); | ||
frame.getContentPane().add(sp, BorderLayout.CENTER); | ||
sp.setDividerSize(-50); | ||
divSize = sp.getDividerSize(); | ||
((BasicSplitPaneUI)sp.getUI()).getDivider().setDividerSize(-50); | ||
basicDivSize = ((BasicSplitPaneUI)sp.getUI()).getDivider(). | ||
getDividerSize(); | ||
frame.setSize(new Dimension(400,200)); | ||
frame.setVisible(true); | ||
}); | ||
try { | ||
Thread.sleep(1000); | ||
} catch(Exception e){} | ||
SwingUtilities.invokeAndWait(()->frame.dispose()); | ||
System.out.println(divSize); | ||
System.out.println(basicDivSize); | ||
System.out.println((Integer)UIManager.get("SplitPane.dividerSize")); | ||
if (divSize < 0 || basicDivSize < 0) { | ||
throw new RuntimeException("Negative divider size"); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't the same as ignoring it. Suppose we do
setDividerSize(5);
setDividerSize(-1);
what is the value after both of these - per your ignoring code 5, but per your doc it will be whatever the default was before you started to change it.
I think it sufficient to say it will be ignored and drop the 2nd clause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Modified javadoc and CSR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, but because I focused on the rest of it, I overlooked you had made this an implNote.
That seems odd. Do you really intend to imply that some other implementation of Java should be allowed
to do something with negative values ? If so that would be a compatibility issue ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, actually I was thinking in that sense, as I was not sure if other impl. will allow -ve values and just wanted to mention that our impl dont.
But, I guess as you pointed, we should make it disallowed for all. Modified PR and CSR.