Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290846: sun/tools/jstatd/JstatdTest* tests should use VM options #9604

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Jul 21, 2022

Propagate test.vm.opts/test.java.opts to tested process. Also, accept the output of non-generation (ZGC) GC as valid.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290846: sun/tools/jstatd/JstatdTest* tests should use VM options

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9604/head:pull/9604
$ git checkout pull/9604

Update a local copy of the PR:
$ git checkout pull/9604
$ git pull https://git.openjdk.org/jdk pull/9604/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9604

View PR using the GUI difftool:
$ git pr show -t 9604

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9604.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2022

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 21, 2022
@openjdk
Copy link

openjdk bot commented Jul 21, 2022

@lmesnik The following labels will be automatically applied to this pull request:

  • core-libs
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jul 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 27, 2022

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290846: sun/tools/jstatd/JstatdTest* tests should use VM options

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

  • c1a3347: 8291358: Fix the "overridding" typo
  • 37b08c7: 8237913: G1CollectedHeap::heap_region_containing shouldn't be a template
  • dc74ea2: 8291048: x86: compiler/c2/irTests/TestAutoVectorization2DArray.java fails with lower SSE
  • c104089: 8290848: LoadLibraryUnload.java still fails with "Too few cleared WeakReferences"
  • 9234624: Merge
  • 36c00fd: 8291006: java/foreign/TestUnsupportedPlatform fails after JDK-8290455
  • 8c9d5ad: 8290455: jck test api/java_lang/foreign/VaList/Empty.html fails on some platforms
  • c29242e: 8290460: Alpine: disable some panama tests that rely on std::thread
  • 2f3e494: 8290074: Remove implicit arguments for RegisterMap constructor
  • e804236: 8291289: gc/TestPLABAdaptToMinTLABSize fails after JDK-8289137
  • ... and 37 more: https://git.openjdk.org/jdk/compare/59d85bad348f7787533ff38942dab2811c4eb623...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 27, 2022
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks,
Serguei

@lmesnik
Copy link
Member Author

lmesnik commented Jul 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 28, 2022

Going to push as commit 348a052.
Since your change was applied there have been 49 commits pushed to the master branch:

  • bc6a3c7: 8290739: Simplify storage of dump-time class information
  • 16a1275: 8290943: Fix several IR test issues on SVE after JDK-8289801
  • c1a3347: 8291358: Fix the "overridding" typo
  • 37b08c7: 8237913: G1CollectedHeap::heap_region_containing shouldn't be a template
  • dc74ea2: 8291048: x86: compiler/c2/irTests/TestAutoVectorization2DArray.java fails with lower SSE
  • c104089: 8290848: LoadLibraryUnload.java still fails with "Too few cleared WeakReferences"
  • 9234624: Merge
  • 36c00fd: 8291006: java/foreign/TestUnsupportedPlatform fails after JDK-8290455
  • 8c9d5ad: 8290455: jck test api/java_lang/foreign/VaList/Empty.html fails on some platforms
  • c29242e: 8290460: Alpine: disable some panama tests that rely on std::thread
  • ... and 39 more: https://git.openjdk.org/jdk/compare/59d85bad348f7787533ff38942dab2811c4eb623...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 28, 2022
@openjdk openjdk bot closed this Jul 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 28, 2022
@openjdk
Copy link

openjdk bot commented Jul 28, 2022

@lmesnik Pushed as commit 348a052.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants