8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures." #9610

Bhavana-Kilambi · 2022-07-22T09:40:37Z

… "IRViolationException: There were one or multiple IR rule failures."

The IR test - TestAutoVecIntMinMax.java was introduced in https://bugs.openjdk.org/browse/JDK-8288107 to test IR generation of MaxV and MinV nodes when the MinI/MaxI nodes are auto-vectorized.
However, the corresponding vector ISA support for min/max on x64 machines is only available in SSE versions > 3 and AVX.
The "@requires" annotation in the JTREG test has been modified to use the whitelisted flags instead.
Deleting the entry for this JTREG test in test/hotspot/jtreg/ProblemList.txt.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures."

Reviewers

Jie Fu (@DamonFool - Reviewer)
Vladimir Kozlov (@vnkozlov - Reviewer)
Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9610/head:pull/9610
$ git checkout pull/9610

Update a local copy of the PR:
$ git checkout pull/9610
$ git pull https://git.openjdk.org/jdk pull/9610/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9610

View PR using the GUI difftool:
$ git pr show -t 9610

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9610.diff

@requires

… "IRViolationException: There were one or multiple IR rule failures." The IR test - TestAutoVecIntMinMax.java was introduced in https://bugs.openjdk.org/browse/JDK-8288107 to test IR generation of MaxV and MinV nodes when the MinI/MaxI nodes are auto-vectorized. However, the corresponding vector ISA support for min/max on x64 machines is only available in SSE versions > 3 and AVX. The "@requires" annotation in the JTREG test has been modified to use the whitelisted flags instead. Deleting the entry for this JTREG test in test/hotspot/jtreg/ProblemList.txt.

bridgekeeper · 2022-07-22T09:41:09Z

👋 Welcome back Bhavana-Kilambi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-07-22T09:44:53Z

@Bhavana-Kilambi The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-07-22T09:47:25Z

Webrevs

00: Full (dbace8a1)

DamonFool

LGTM

openjdk · 2022-07-22T11:29:39Z

@Bhavana-Kilambi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures."

Reviewed-by: jiefu, kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

228e8e9: 8290700: Optimize AArch64 nmethod entry barriers
852e71d: 8290870: NMT: Increase MallocSiteTable size and allocate it only when needed
0599a05: 8290900: Build failure with Clang 14+ due to function warning attribute
987656d: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java
2660a92: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload
ef8486a: 8286270: [java.desktop] Replace color search in XColors with a switch statement
62f2263: 8290861: Remove unused field URLJarFile.BUF_SIZE
b28f9da: 8290688: Optimize x86_64 nmethod entry barriers
54854d9: 8256811: Delayed/missed jdwp class unloading events
75c1e99: 8289572: InputStream wrapping with BufferedInputStream is redundant in HttpTimestamper
... and 1 more: https://git.openjdk.org/jdk/compare/e9f97b2e8cf301ba6b69101e5efc5c71d26bc87b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@DamonFool, @vnkozlov, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Bhavana-Kilambi · 2022-07-22T11:53:28Z

There are a couple of macos failures due to "wget". Should these runs be triggered again?

TobiHartmann · 2022-07-22T12:23:01Z

I'll run testing and report back once it passed.

vnkozlov

Good.

I looked on Tobias's testing and verified that the test skipped with UseSSE < 4 and it is executed and passed in other configured.

Bhavana-Kilambi · 2022-07-22T21:06:21Z

/integrate

Bhavana-Kilambi · 2022-07-22T21:06:39Z

Thank you for testing this patch.

openjdk · 2022-07-22T21:07:20Z

@Bhavana-Kilambi
Your change (at version dbace8a) is now ready to be sponsored by a Committer.

TobiHartmann · 2022-07-25T09:05:16Z

/sponsor

openjdk · 2022-07-25T09:08:32Z

Going to push as commit 80dc6ce.
Since your change was applied there have been 11 commits pushed to the master branch:

228e8e9: 8290700: Optimize AArch64 nmethod entry barriers
852e71d: 8290870: NMT: Increase MallocSiteTable size and allocate it only when needed
0599a05: 8290900: Build failure with Clang 14+ due to function warning attribute
987656d: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java
2660a92: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload
ef8486a: 8286270: [java.desktop] Replace color search in XColors with a switch statement
62f2263: 8290861: Remove unused field URLJarFile.BUF_SIZE
b28f9da: 8290688: Optimize x86_64 nmethod entry barriers
54854d9: 8256811: Delayed/missed jdwp class unloading events
75c1e99: 8289572: InputStream wrapping with BufferedInputStream is redundant in HttpTimestamper
... and 1 more: https://git.openjdk.org/jdk/compare/e9f97b2e8cf301ba6b69101e5efc5c71d26bc87b...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-07-25T09:08:49Z

@TobiHartmann @Bhavana-Kilambi Pushed as commit 80dc6ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot changed the title ~~8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with…~~ 8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures." Jul 22, 2022

openjdk bot added the rfr label Jul 22, 2022

openjdk bot added the hotspot-compiler label Jul 22, 2022

DamonFool approved these changes Jul 22, 2022

View reviewed changes

openjdk bot added the ready label Jul 22, 2022

vnkozlov approved these changes Jul 22, 2022

View reviewed changes

openjdk bot added the sponsor label Jul 22, 2022

TobiHartmann approved these changes Jul 25, 2022

View reviewed changes

openjdk bot added the integrated label Jul 25, 2022

openjdk bot closed this Jul 25, 2022

openjdk bot removed ready rfr sponsor labels Jul 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures." #9610

8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures." #9610

Bhavana-Kilambi commented Jul 22, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jul 22, 2022

openjdk bot commented Jul 22, 2022

mlbridge bot commented Jul 22, 2022

DamonFool left a comment

openjdk bot commented Jul 22, 2022 •

edited

Loading

Bhavana-Kilambi commented Jul 22, 2022

TobiHartmann commented Jul 22, 2022

vnkozlov left a comment

Bhavana-Kilambi commented Jul 22, 2022

Bhavana-Kilambi commented Jul 22, 2022

openjdk bot commented Jul 22, 2022

TobiHartmann commented Jul 25, 2022

openjdk bot commented Jul 25, 2022

openjdk bot commented Jul 25, 2022

8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures." #9610

8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures." #9610

Conversation

Bhavana-Kilambi commented Jul 22, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jul 22, 2022

openjdk bot commented Jul 22, 2022

mlbridge bot commented Jul 22, 2022

Webrevs

DamonFool left a comment

Choose a reason for hiding this comment

openjdk bot commented Jul 22, 2022 • edited Loading

Bhavana-Kilambi commented Jul 22, 2022

TobiHartmann commented Jul 22, 2022

vnkozlov left a comment

Choose a reason for hiding this comment

Bhavana-Kilambi commented Jul 22, 2022

Bhavana-Kilambi commented Jul 22, 2022

openjdk bot commented Jul 22, 2022

TobiHartmann commented Jul 25, 2022

openjdk bot commented Jul 25, 2022

openjdk bot commented Jul 25, 2022

Bhavana-Kilambi commented Jul 22, 2022 •

edited by openjdk bot

Loading

openjdk bot commented Jul 22, 2022 •

edited

Loading