8290972: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java

[RogerRiggs]

ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
The earlier fix is not sufficient for higher tier tests possibly related to -Xcomp.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290972: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java

Reviewers

• Iris Clark (@irisclark - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9630/head:pull/9630
$ git checkout pull/9630

Update a local copy of the PR:
$ git checkout pull/9630
$ git pull https://git.openjdk.org/jdk pull/9630/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9630

View PR using the GUI difftool:
$ git pr show -t 9630

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9630.diff

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RogerRiggs To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[RogerRiggs]

/label core-libs

[openjdk]

@RogerRiggs
The core-libs label was successfully added.

[mlbridge]

Webrevs

• 00: Full (c0f58280)

[openjdk]

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290972: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java

Reviewed-by: iris, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 0ca5cb1: 8290834: Improve potentially confusing documentation on collection of profiling information
• 7c3cfd1: 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jaikiran]

Hello Roger, the change looks fine to me. There's a mention that this issue was noticed once on a setup where -Xcomp wasn't used but -Xcheck:jni was used. Would problem listing this only in this ProblemList-Xcomp.txt file, address that one too?

[RogerRiggs]

Hello Roger, the change looks fine to me. There's a mention that this issue was noticed once on a setup where -Xcomp wasn't used but -Xcheck:jni was used. Would problem listing this only in this ProblemList-Xcomp.txt file, address that one too?

Though the problem is unlikely to be related to -Xcheck:jni, the bulk of the failures seem to be -Xcomp related, this will cut down on the noise in the higher tiers.

[RogerRiggs]

/integrate

[openjdk]

Going to push as commit 28bbdc5.
Since your change was applied there have been 3 commits pushed to the master branch:

• a6faf5d: 8290485: [vector] REVERSE_BYTES for byte type should not emit any instructions
• 0ca5cb1: 8290834: Improve potentially confusing documentation on collection of profiling information
• 7c3cfd1: 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"

Your commit was automatically rebased without conflicts.

[openjdk]

@RogerRiggs Pushed as commit 28bbdc5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.