8291559: x86: compiler/vectorization/TestReverseBitsVector.java fails

[shipilev]

See the bug report for reproducer.

The test checks for avx2, but that is not enough for x86_32, as you can have avx2 supported, but no Reverse* nodes emitted anyway. It seems the test is only viable on x86_64 anyway, so fix just gates the tests on that arch.

Additional testing:

• Affected test on Linux x86_32, now skipped
• Affected test on Linux x86_64, still passes

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291559: x86: compiler/vectorization/TestReverseBitsVector.java fails

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9685/head:pull/9685
$ git checkout pull/9685

Update a local copy of the PR:
$ git checkout pull/9685
$ git pull https://git.openjdk.org/jdk pull/9685/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9685

View PR using the GUI difftool:
$ git pr show -t 9685

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9685.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a762898c)

[vnkozlov]

Trivial.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291559: x86: compiler/vectorization/TestReverseBitsVector.java fails

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• cc2861a: 8290901: Reduce use of -source in langtools tests
• 64a1a08: 8289647: AssertionError during annotation processing of record related tests
• 95fc16b: 8290525: Move HeapRegion::_compaction_top to G1FullCollector
• f58e08e: 8290715: Fix incorrect uses of G1CollectedHeap::heap_region_containing()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thank you!

/integrate

[openjdk]

Going to push as commit acbe093.
Since your change was applied there have been 11 commits pushed to the master branch:

• 32d410a: 8290868: NMT: MallocSiteTable statistics improvements
• 3579024: 8288904: Incorrect memory ordering in UL
• 470c0eb: 8290740: Catalog not used when the handler is null
• dd9bd31: 8289688: jfr command hangs when it processes invalid file
• 8179a19: 8290243: move seeTagToContent from HtmlDocletWriter to TagletWriterImpl
• 15943e4: 8282666: nsk/jvmti/PopFrame/popframe004 failed with: TEST FAILED: 30 JVMTI events were generated by the function PopFrame()
• 0bcf176: 6227536: KeyGenerator.init() methods do not throw IllegalArgumentException for keysize == 0
• cc2861a: 8290901: Reduce use of -source in langtools tests
• 64a1a08: 8289647: AssertionError during annotation processing of record related tests
• 95fc16b: 8290525: Move HeapRegion::_compaction_top to G1FullCollector
• ... and 1 more: https://git.openjdk.org/jdk/compare/18cd16d2eae2ee624827eb86621f3a4ffd98fe8c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit acbe093.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.