Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291725: Leftover marks when VM shutdown aborts bitmap clearing make mixed gc fail #9735

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Aug 3, 2022

Hi all,

can I have reviews for this change that removes stray bits on the mark bitmap during mixed gcs during shutdown?

So it may happen that after shutdown aborts the "Concurrent Cleanup for Next Mark" phase which leaves marks on the bitmaps (we want to shut down asap after all). However a mixed gc afterwards might notice these marks and in this case asserts, but in case of an evacuation failure might also trip over these additional marks.

Testing: tier1-5, I did not manage to reproduce this, but it's "obvious" given the failure mode, particularly because recently there has been a similar issue with full gc in JDK-8274007

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291725: Leftover marks when VM shutdown aborts bitmap clearing make mixed gc fail

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9735/head:pull/9735
$ git checkout pull/9735

Update a local copy of the PR:
$ git checkout pull/9735
$ git pull https://git.openjdk.org/jdk pull/9735/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9735

View PR using the GUI difftool:
$ git pr show -t 9735

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9735.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2022

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8291725 8291725: Leftover marks when VM shutdown aborts bitmap clearing make mixed gc fail Aug 3, 2022
@openjdk
Copy link

openjdk bot commented Aug 3, 2022

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 3, 2022
@tschatzl tschatzl marked this pull request as ready for review August 4, 2022 15:33
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 4, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2022

Webrevs

Copy link
Member

@walulyai walulyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@openjdk
Copy link

openjdk bot commented Aug 8, 2022

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291725: Leftover marks when VM shutdown aborts bitmap clearing make mixed gc fail

Reviewed-by: iwalulya, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 400 new commits pushed to the master branch:

  • 6a1e98c: 8293213: G1: Remove redundant assertion in G1RemSet::clean_card_before_refine
  • a92c1ff: 8287912: GTK L&F : Background of tree icons are red
  • 272745b: 8293340: Remove unused _code in {Zero,Template}InterpreterGenerator
  • 26f2a97: 8290561: Coalesce incubator-module warnings for single-file source-code programs
  • 8e22f2b: 8293361: GHA: dump config.log in case of configure failure
  • b17758a: 8247283: Enable the new conformant preprocessor option in Visual Studio
  • 1bed23a: 8293353: [BACKOUT] G1: Remove redundant is-marking-active checks in C1 barrier
  • 4955835: 8282434: Leading combining diacritic character in string renders incorrectly
  • ef20ffe: 8293159: Use try-with-resources in X11FontManager.registerFontDir
  • 056ed48: 8293180: JQuery UI license file not updated
  • ... and 390 more: https://git.openjdk.org/jdk/compare/0971d3464609bf4124df460ea73ff761d7e0f7b2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 8, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2022

@tschatzl This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@tschatzl
Copy link
Contributor Author

tschatzl commented Sep 5, 2022

Ping for a second reviewer....

Copy link
Member

@albertnetymk albertnetymk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe JDK-8293431 would be a cleaner solution to this problem. This fix is enough for now.

@tschatzl
Copy link
Contributor Author

tschatzl commented Sep 6, 2022

Thanks for your reviews. I will look into https://bugs.openjdk.org/browse/JDK-8293431 on the side.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 6, 2022

Going to push as commit b2067e6.
Since your change was applied there have been 400 commits pushed to the master branch:

  • 6a1e98c: 8293213: G1: Remove redundant assertion in G1RemSet::clean_card_before_refine
  • a92c1ff: 8287912: GTK L&F : Background of tree icons are red
  • 272745b: 8293340: Remove unused _code in {Zero,Template}InterpreterGenerator
  • 26f2a97: 8290561: Coalesce incubator-module warnings for single-file source-code programs
  • 8e22f2b: 8293361: GHA: dump config.log in case of configure failure
  • b17758a: 8247283: Enable the new conformant preprocessor option in Visual Studio
  • 1bed23a: 8293353: [BACKOUT] G1: Remove redundant is-marking-active checks in C1 barrier
  • 4955835: 8282434: Leading combining diacritic character in string renders incorrectly
  • ef20ffe: 8293159: Use try-with-resources in X11FontManager.registerFontDir
  • 056ed48: 8293180: JQuery UI license file not updated
  • ... and 390 more: https://git.openjdk.org/jdk/compare/0971d3464609bf4124df460ea73ff761d7e0f7b2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 6, 2022
@openjdk openjdk bot closed this Sep 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 6, 2022
@openjdk
Copy link

openjdk bot commented Sep 6, 2022

@tschatzl Pushed as commit b2067e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8291725-bitmap-marks-during-shutdown branch October 14, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants