New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8291725: Leftover marks when VM shutdown aborts bitmap clearing make mixed gc fail #9735
8291725: Leftover marks when VM shutdown aborts bitmap clearing make mixed gc fail #9735
Conversation
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
@tschatzl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 400 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@tschatzl This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Ping for a second reviewer.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe JDK-8293431 would be a cleaner solution to this problem. This fix is enough for now.
Thanks for your reviews. I will look into https://bugs.openjdk.org/browse/JDK-8293431 on the side. /integrate |
Going to push as commit b2067e6.
Your commit was automatically rebased without conflicts. |
Hi all,
can I have reviews for this change that removes stray bits on the mark bitmap during mixed gcs during shutdown?
So it may happen that after shutdown aborts the "Concurrent Cleanup for Next Mark" phase which leaves marks on the bitmaps (we want to shut down asap after all). However a mixed gc afterwards might notice these marks and in this case asserts, but in case of an evacuation failure might also trip over these additional marks.
Testing: tier1-5, I did not manage to reproduce this, but it's "obvious" given the failure mode, particularly because recently there has been a similar issue with full gc in JDK-8274007
Thanks,
Thomas
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9735/head:pull/9735
$ git checkout pull/9735
Update a local copy of the PR:
$ git checkout pull/9735
$ git pull https://git.openjdk.org/jdk pull/9735/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9735
View PR using the GUI difftool:
$ git pr show -t 9735
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9735.diff