8291266: RenderPerfTest: missing content while rendering some primitives

[avu]

Do not cause redundant endEncoder calls with batch processing of drawing primitives

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291266: RenderPerfTest: missing content while rendering some primitives

Reviewers

• Ajit Ghaisas (@aghaisas - Committer)
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9756/head:pull/9756
$ git checkout pull/9756

Update a local copy of the PR:
$ git checkout pull/9756
$ git pull https://git.openjdk.org/jdk pull/9756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9756

View PR using the GUI difftool:
$ git pr show -t 9756

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9756.diff

[bridgekeeper]

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@avu The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mrserb]

Is it possible to integrate DrawTest.java as a test case?

[mlbridge]

Webrevs

• 01: Full - Incremental (26a9e3f0)
• 00: Full (a55f8f17)

[avu]

Looks like the only way is to use Robot. The problem is not reproducible with VolatileImage. I'll try to come up with something reliable.

[prrace]

Does this only show up as a problem on certain configurations ?
I ran your original test on my 16" x64 macbook pro and I wasn't sure what it was trying to show ...

[avu]

The problem is only reproducible on M1 hardware (I've just double-checked that it's not reproducible on x64). The idea of the test is to trigger batch rendering introduced in JDK-8288948

[aghaisas]

Looks good to me!

[openjdk]

@avu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291266: RenderPerfTest: missing content while rendering some primitives

Reviewed-by: aghaisas, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

• a28ab7b: 8288568: Reduce runtime of java.security microbenchmarks
• 7ea9ba1: 8292064: Convert java/lang/management/MemoryMXBean shell tests to java version
• fc1d94e: 8292232: AIX build failure by JDK-8290840
• a9bc149: 8292216: Remove modules/packages_unloading_do
• 1c0f0f4: 8292077: G1 nmethod entry barriers don't keep oops alive
• ad5f628: 8292140: (fs) Needless instanceof check in RegistryFileTypeDetector
• 2ddf728: 8292026: Remove redundant allocations from DoubleByteEncoder
• 3aaffd6: 8292071: NMT: move MallocHeader to its own header and inline header checks
• 85a6023: Merge
• 4c6d22a: 8288769: Revert unintentional change to deflate.c
• ... and 92 more: https://git.openjdk.org/jdk/compare/1b66cecd311cc56c968134ae3f8aeff2e8bfc970...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[avu]

/integrate

[openjdk]

Going to push as commit 871b7da.
Since your change was applied there have been 111 commits pushed to the master branch:

• 0c40128: 7194212: NPE in Flow.visitIdent
• 6eb7c3a: 8290732: JNI DestroyJavaVM can start shutdown when one non-daemon thread remains
• 083e014: 8292233: Increase symtab hash table size
• 45e5b31: 8292244: Remove unnecessary include directories
• 9bfffa0: 8291945: Add OSInfo API for static OS information
• bd58553: 8290833: Remove ConstantPoolCache::walk_entries_for_initialization()
• 755ecf6: 8292153: x86: Represent Registers as values
• dedc05c: 8291640: java/beans/XMLDecoder/8028054/Task.java should use the 3-arg Class.forName
• 3d20a8b: 8291959: FileFontStrike#initNative does not properly initialize IG Table on Windows
• a28ab7b: 8288568: Reduce runtime of java.security microbenchmarks
• ... and 101 more: https://git.openjdk.org/jdk/compare/1b66cecd311cc56c968134ae3f8aeff2e8bfc970...master

Your commit was automatically rebased without conflicts.

[openjdk]

@avu Pushed as commit 871b7da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.