7189422: [macosx] Submenu's arrow have a wrong position

[prsadhuk]

Issue is Arrow in submenu with empty title have a wrong position in Aqua L&F as can be seen

which is because the text being null/empty, labelR rectangle width/height is 0 so arrowIcon y coordinate becomes -ve as per the calculation in layoutMenuItem(). Although it seems logical to me to not show the arrow if submenu text is null, but
whereas for other L&F, it is shown as this
for Metal

for Nimbus

so the fix is made in Aqua L&F to show as other L&F as

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-7189422: [macosx] Submenu's arrow have a wrong position

Reviewers

• Phil Race (@prrace - Reviewer)
• Damon Nguyen (@DamonGuy - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9769/head:pull/9769
$ git checkout pull/9769

Update a local copy of the PR:
$ git checkout pull/9769
$ git pull https://git.openjdk.org/jdk pull/9769/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9769

View PR using the GUI difftool:
$ git pr show -t 9769

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9769.diff

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (84825b77)

[AJ1062910]

delete unused code

[prrace]

May I take it that you verified this doesn't have any adverse effects on submenus with text :?

[prsadhuk]

Yes, with fix it is

whereas without fix it is

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7189422: [macosx] Submenu's arrow have a wrong position

Reviewed-by: prr, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 385 new commits pushed to the master branch:

• c3d3662: 8292313: 2 runtime/cds/appcds tests fail after JDK-8284313
• 3e12241: 8290775: Some doc errors in DerOutputStream.java
• ec53fba: 8292361: Build failure on PPC64 BE after JDK-8290840
• 4cc6cb9: 8290041: ModuleDescriptor.hashCode is inconsistent
• d1edda8: 8292338: aarch64: Use cbnz instruction in gen_continuation_enter when possible
• 21f4eb2: 6521141: DebugGraphics NPE @ setFont();
• 6e6ae59: 8292286: Convert PlaceholderTable to ResourceHashtable
• ea2c82e: 8291949: Unexpected extending of SupportedGroups
• b5707b0: 8292196: Reduce runtime of java.util.regex microbenchmarks
• b00eede: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth
• ... and 375 more: https://git.openjdk.org/jdk/compare/6e18883d8ffd9a7b7d495da05e9859dc1d1a2677...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonGuy]

Applied your changes and ran the test. The fix works as described.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit d5167a9.
Since your change was applied there have been 530 commits pushed to the master branch:

• 512fee1: 8292972: Initialize fields if CodeBlobIterator shortcuts without heaps
• a476ec5: 8292983: ModuleReferenceImpl.computeHash should record algorithm for cache checks
• 99cab6a: 8292911: Add a note about jtreg failure handlers in the testing doc
• f6b6360: 8289949: Improve test coverage for XPath: operators
• b0e0b87: 8292917: [JVMCI] Extend InstalledCode API to make an nmethod non entrant.
• 1500d3d: 8292994: ProblemList vmTestbase/gc/lock/jni/jnilock001/TestDescription.java
• 4e457ac: 8291760: PipelineLeaksFD.java still fails: More or fewer pipes than expected
• 774edeb: 8271615: vmTestbase/vm/jit/LongTransitions/ test fail due to locale mismatch
• 9a0d1e7: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
• c74b6d4: 8292562: (fc) Use copy_file_range in FileChannel::transferTo on Linux
• ... and 520 more: https://git.openjdk.org/jdk/compare/6e18883d8ffd9a7b7d495da05e9859dc1d1a2677...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit d5167a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.