JDK-8291901: IGV: Preference menu disappears after JDK-8288750

[tobiasholenstein]

The Options menu is places by default in Tools in the menu bar. On macOS however the Options menu (called Preference on macOS) is placed in the macOS default application menu (idealgraphvisualizer) the options bar. Because the Tools menu was always empty on macOS it was removed in JDK-8288750. Unfortunately, this made the Options menu inaccessible on Linux.

The problem is solved by putting the Options menu in a separate tab in the menu bar and keeping the Tools menu hidden:

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291901: IGV: Preference menu disappears after JDK-8288750

Reviewers

• Roberto Castañeda Lozano (@robcasloz - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9771/head:pull/9771
$ git checkout pull/9771

Update a local copy of the PR:
$ git checkout pull/9771
$ git pull https://git.openjdk.org/jdk pull/9771/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9771

View PR using the GUI difftool:
$ git pr show -t 9771

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9771.diff

[bridgekeeper]

👋 Welcome back tholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tobiasholenstein The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (62890037)

[robcasloz]

Thanks for fixing this @tobiasholenstein!

[openjdk]

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291901: IGV: Preference menu disappears after JDK-8288750

Reviewed-by: rcastanedalo, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 8e2c006: 8291957: Redundant import statements in sun.security.ec
• ae52053: 8291954: Use Optional.isEmpty instead of !Optional.isPresent in java.base
• 87cda21: Merge
• 5963300: 8290562: ThreadMXBean.getThread{Cpu,User}Time fails with -XX:-VMContinuations
• 0657acf: 8289249: Add methods to Elements for record constructors
• b66a0d1: 8291992: [REDO2] ProblemList multiple tests in -Xcomp mode due to JDK-8291649
• 9bff3b7: 8291990: [REDO] ProblemList multiple tests in -Xcomp mode due to JDK-8291649
• f9bb367: 8291653: G1 refinement incorrectly expects always-valid HeapRegion out of the Hot Card Cache
• b17a745: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value
• 0da4314: 8288732: Reduce runtime of java.util.concurrent microbenchmarks
• ... and 3 more: https://git.openjdk.org/jdk/compare/b0d6952811c2b29115b69427fe148ee6bce41710...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good.

[tobiasholenstein]

Thanks @robcasloz and @TobiHartmann for the reviews!

/integrate

[openjdk]

Going to push as commit 20123ea.
Since your change was applied there have been 13 commits pushed to the master branch:

• 8e2c006: 8291957: Redundant import statements in sun.security.ec
• ae52053: 8291954: Use Optional.isEmpty instead of !Optional.isPresent in java.base
• 87cda21: Merge
• 5963300: 8290562: ThreadMXBean.getThread{Cpu,User}Time fails with -XX:-VMContinuations
• 0657acf: 8289249: Add methods to Elements for record constructors
• b66a0d1: 8291992: [REDO2] ProblemList multiple tests in -Xcomp mode due to JDK-8291649
• 9bff3b7: 8291990: [REDO] ProblemList multiple tests in -Xcomp mode due to JDK-8291649
• f9bb367: 8291653: G1 refinement incorrectly expects always-valid HeapRegion out of the Hot Card Cache
• b17a745: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value
• 0da4314: 8288732: Reduce runtime of java.util.concurrent microbenchmarks
• ... and 3 more: https://git.openjdk.org/jdk/compare/b0d6952811c2b29115b69427fe148ee6bce41710...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tobiasholenstein Pushed as commit 20123ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.