4958071: (spec) confusing exception list for javax.crypto.Cipher.init(...) for

[driverkt]

Fix for JDK-4958071 to add additional @throws stanza to javadocs for all init methods

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-4958071: (spec) confusing exception list for javax.crypto.Cipher.init(...) for
• JDK-8292300: (spec) confusing exception list for javax.crypto.Cipher.init(...) (CSR)

Reviewers

• Valerie Peng (@valeriepeng - Reviewer) ⚠️ Review applies to a11d57ab
• Bradford Wetmore (@bradfordwetmore - Reviewer) ⚠️ Review applies to a11d57ab

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9860/head:pull/9860
$ git checkout pull/9860

Update a local copy of the PR:
$ git checkout pull/9860
$ git pull https://git.openjdk.org/jdk pull/9860/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9860

View PR using the GUI difftool:
$ git pr show -t 9860

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9860.diff

[driverkt]

/issue add 4958071

[driverkt]

/csr needed

[bridgekeeper]

👋 Welcome back kdriver! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@driverkt This issue is referenced in the PR title - it will now be updated.

[openjdk]

@driverkt has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@driverkt please create a CSR request for issue JDK-4958071 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@driverkt The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (54c57179)
• 01: Full - Incremental (d0f62e66)
• 00: Full (a11d57ab)

[valeriepeng]

Looks good. Thanks.

[bradfordwetmore]

LGTM, but needs test cases.

[driverkt]

@bradfordwetmore test added

[driverkt]

/integrate

[openjdk]

@driverkt This pull request has not yet been marked as ready for integration.

[driverkt]

/integrate

[openjdk]

@driverkt This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

4958071: (spec) confusing exception list for javax.crypto.Cipher.init(...) for

Reviewed-by: valeriep, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 188 new commits pushed to the master branch:

• d3d2e66: 8293009: Remove unused field 'millisPerHour' in DateFormatSymbols
• f3ebb42: 8293036: x86_64: Move Continuation-related stub methods to MacroAssembler
• 1576f99: 8288759: GCC 12 fails to compile signature.cpp due to -Wstringop-overread
• f285cea: 8293037: Remove DebuggerBase.writeBytes() and related code from SA
• 343333a: 8293004: (fs) FileChannel.transferXXX use of copy_file_range needs fallback handling for ENOSYS
• b3450e9: 8292850: Unused field 'expiredTimersKey' in javax.swing.TimerQueue
• 6b7d4b1: 8293028: Remove GenCollectedHeap::handle_failed_promotion
• 21a7369: 8292575: riscv: Represent Registers as values
• 4a28f37: 8291792: DefaultStyledDocument.setCharacterAttributes accepts negative length
• f766d92: 8290344: Start/stop displaysync affects performance in metal rendering pipeline
• ... and 178 more: https://git.openjdk.org/jdk/compare/22d6d315f2b1e0838d07bd30b6c2d58b5f98878b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@valeriepeng, @bradfordwetmore) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@driverkt
Your change (at version 54c5717) is now ready to be sponsored by a Committer.

[valeriepeng]

/sponsor

[openjdk]

Going to push as commit 550e5d7.
Since your change was applied there have been 188 commits pushed to the master branch:

• d3d2e66: 8293009: Remove unused field 'millisPerHour' in DateFormatSymbols
• f3ebb42: 8293036: x86_64: Move Continuation-related stub methods to MacroAssembler
• 1576f99: 8288759: GCC 12 fails to compile signature.cpp due to -Wstringop-overread
• f285cea: 8293037: Remove DebuggerBase.writeBytes() and related code from SA
• 343333a: 8293004: (fs) FileChannel.transferXXX use of copy_file_range needs fallback handling for ENOSYS
• b3450e9: 8292850: Unused field 'expiredTimersKey' in javax.swing.TimerQueue
• 6b7d4b1: 8293028: Remove GenCollectedHeap::handle_failed_promotion
• 21a7369: 8292575: riscv: Represent Registers as values
• 4a28f37: 8291792: DefaultStyledDocument.setCharacterAttributes accepts negative length
• f766d92: 8290344: Start/stop displaysync affects performance in metal rendering pipeline
• ... and 178 more: https://git.openjdk.org/jdk/compare/22d6d315f2b1e0838d07bd30b6c2d58b5f98878b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@valeriepeng @driverkt Pushed as commit 550e5d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.