New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292314: Cleanup legacy address handling #9866
Conversation
👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into |
@TheShermanTanker The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't a mistake. It was deliberate. That function used to be looked up at runtime.
However it was obsoleted by http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/75755e92430c
So it is safe to remove it now.
@TheShermanTanker This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
I see, will change the issue to reflect that before integrating |
/integrate |
@TheShermanTanker |
/integrate |
@TheShermanTanker |
/integrate |
@TheShermanTanker |
/sponsor |
Going to push as commit 95a33fe.
Your commit was automatically rebased without conflicts. |
@prrace @TheShermanTanker Pushed as commit 95a33fe. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Cleanup legacy address check in libsplashscreen obsoleted by http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/75755e92430c
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9866/head:pull/9866
$ git checkout pull/9866
Update a local copy of the PR:
$ git checkout pull/9866
$ git pull https://git.openjdk.org/jdk pull/9866/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9866
View PR using the GUI difftool:
$ git pr show -t 9866
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9866.diff