8292328 : AccessibleActionsTest.java test instruction for show popup on JLabel did not specify shift key

[lawrence-andrew]

Corrected the test instruction to show the popup menu on JLabel when voice over is enabled .

@shurymury

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292328: AccessibleActionsTest.java test instruction for show popup on JLabel did not specify shift key

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9868/head:pull/9868
$ git checkout pull/9868

Update a local copy of the PR:
$ git checkout pull/9868
$ git pull https://git.openjdk.org/jdk pull/9868/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9868

View PR using the GUI difftool:
$ git pr show -t 9868

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9868.diff

[bridgekeeper]

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lawrence-andrew The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e566299e)

[honkar-jdk]

Tested on Mac 12.3, (VO+Shift+m) for menu expansion works. The first and third tests work fine. In the second test (JTree), first level of expansion works on pressing (VO+space) but the expansion to leaf nodes doesn't occur on subsequent (VO+space).

[openjdk]

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292328: AccessibleActionsTest.java test instruction for show popup on JLabel did not specify shift key

Reviewed-by: serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 476 new commits pushed to the master branch:

• 5285035: 8294075: gtest/AsyncLogGtest crashes with SEGV
• 696287d: 8294037: Using alias template to unify hashtables in AsyncLogWriter
• 48cc156: 8293331: Refactor FileDispatcherImpl into operating system-specific components
• f751e60: 8294197: Zero: JVM_handle_linux_signal should not assume deopt NOPs
• 4a6060b: 8294190: Incorrect check messages in SharedRuntime::generate_uncommon_trap_blob
• 0be2b2c: 8292756: java.lang.AssertionError at at jdk.compiler/com.sun.tools.javac.code.Scope$ScopeImpl.leave(Scope.java:386)
• bc2af47: 8254711: Add java.security.Provider.getService JFR Event
• d781ab0: 8294003: Don't handle si_addr == 0 && si_code == SI_KERNEL SIGSEGVs
• a216960: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops
• 3fa6778: 8292296: Use multiple threads to process ParallelGC deferred updates
• ... and 466 more: https://git.openjdk.org/jdk/compare/1c1c4410b20f598c7e81fae044b6cb298ed12bab...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lawrence-andrew]

/integrate

[openjdk]

@lawrence-andrew
Your change (at version e566299) is now ready to be sponsored by a Committer.

[aivanov-jdk]

/sponsor

[openjdk]

Going to push as commit df53fa7.
Since your change was applied there have been 476 commits pushed to the master branch:

• 5285035: 8294075: gtest/AsyncLogGtest crashes with SEGV
• 696287d: 8294037: Using alias template to unify hashtables in AsyncLogWriter
• 48cc156: 8293331: Refactor FileDispatcherImpl into operating system-specific components
• f751e60: 8294197: Zero: JVM_handle_linux_signal should not assume deopt NOPs
• 4a6060b: 8294190: Incorrect check messages in SharedRuntime::generate_uncommon_trap_blob
• 0be2b2c: 8292756: java.lang.AssertionError at at jdk.compiler/com.sun.tools.javac.code.Scope$ScopeImpl.leave(Scope.java:386)
• bc2af47: 8254711: Add java.security.Provider.getService JFR Event
• d781ab0: 8294003: Don't handle si_addr == 0 && si_code == SI_KERNEL SIGSEGVs
• a216960: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops
• 3fa6778: 8292296: Use multiple threads to process ParallelGC deferred updates
• ... and 466 more: https://git.openjdk.org/jdk/compare/1c1c4410b20f598c7e81fae044b6cb298ed12bab...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk @lawrence-andrew Pushed as commit df53fa7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.