Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292488: JFR: Incorrect comment in ActiveRecordingEvent #9897

Closed
wants to merge 1 commit into from

Conversation

chigiriki
Copy link
Contributor

@chigiriki chigiriki commented Aug 17, 2022

please review this change.
I checked the build succecfully just in case. No error occured.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292488: JFR: Incorrect comment in ActiveRecordingEvent

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9897/head:pull/9897
$ git checkout pull/9897

Update a local copy of the PR:
$ git checkout pull/9897
$ git pull https://git.openjdk.org/jdk pull/9897/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9897

View PR using the GUI difftool:
$ git pr show -t 9897

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9897.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2022

👋 Welcome back chigiriki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@chigiriki The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Aug 17, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2022

Webrevs

@chigiriki chigiriki changed the title 8292488: Incorrect comment in ActiveRecordingEvent 8292488: JFR: Incorrect comment in ActiveRecordingEvent Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@chigiriki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292488: JFR: Incorrect comment in ActiveRecordingEvent

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 0d96546: 8292054: Test runtime/posixSig/TestPosixSig.java fails with 'Test failed, bad output.'
  • e8bc879: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases
  • 494d387: 8280152: AArch64: Reuse runtime call trampolines
  • 8b4e6ba: 8289332: Auto-generate ids for user-defined headings
  • 0fc9263: 8291828: Reduce runtime of java.util.stream microbenchmarks
  • e81210f: 8292352: 32-bit Windows build failures after JDK-8290059
  • f45b840: 8292384: Convert AdapterHandlerTable to ResourceHashtable
  • 0c67fba: 8289049: x86_32 build fails with GCC 11 due to newString646_US warning
  • bf7d6d3: 7132413: [macosx] closed/javax/swing/AbstractButton/5049549/bug5049549.java fails on MacOS
  • e230719: 8292448: Convert BitMapFragmentTable to ResourceHashtable
  • ... and 8 more: https://git.openjdk.org/jdk/compare/da477b13661b39e1f48b674f7fd9ea1d26521fc3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@egahlin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 17, 2022
@egahlin
Copy link
Member

egahlin commented Aug 17, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@egahlin The change author (@chigiriki) must issue an integrate command before the integration can be sponsored.

@chigiriki
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@chigiriki
Your change (at version bbd5e0f) is now ready to be sponsored by a Committer.

@egahlin
Copy link
Member

egahlin commented Aug 18, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

Going to push as commit 20a3cb7.
Since your change was applied there have been 24 commits pushed to the master branch:

  • f567fa0: 8292498: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed with "AssertionError: only show error once expected [1] but found [0]"
  • d00e7b9: 8292544: G1: Remove virtual specifier for methods in G1EdenRegions and G1SurvivorRegions
  • f2773f6: 8292556: Clean up unused Hashtable instantiations
  • d543564: 8289334: Use CSS variables to define fonts and colors
  • 2ee9491: 8289051: C2: Cleanup PhaseCCP::analyze()
  • 32d675c: 8291775: C2: assert(r != __null && r->is_Region()) failed: this phi must have a region
  • 0d96546: 8292054: Test runtime/posixSig/TestPosixSig.java fails with 'Test failed, bad output.'
  • e8bc879: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases
  • 494d387: 8280152: AArch64: Reuse runtime call trampolines
  • 8b4e6ba: 8289332: Auto-generate ids for user-defined headings
  • ... and 14 more: https://git.openjdk.org/jdk/compare/da477b13661b39e1f48b674f7fd9ea1d26521fc3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 18, 2022
@openjdk openjdk bot closed this Aug 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@egahlin @chigiriki Pushed as commit 20a3cb7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants