Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable #9920

Closed

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Aug 18, 2022

Trivial change of removing dead code.

Test: build


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9920/head:pull/9920
$ git checkout pull/9920

Update a local copy of the PR:
$ git checkout pull/9920
$ git pull https://git.openjdk.org/jdk pull/9920/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9920

View PR using the GUI difftool:
$ git pr show -t 9920

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9920.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8292607 8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable Aug 18, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 18, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2022

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and trivial

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 18, 2022
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

Going to push as commit 63a126a.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 7d18ebd: 8292606: G1 and Epsilon header cleanup for JDK-8282729
  • 2edd550: 8292312: Work around memset() called operator new
  • 964aac2: 8292499: CDS ArchivedEnumTest.java fails: object points to a static field that may be reinitialized
  • f85411f: 8292458: Atomic operations on scoped enums don't build with clang
  • 82dbe29: 8292633: runtime/cds/appcds/dynamicArchive/CDSStreamTestDriver.java fails to compile
  • 54ce114: 6587699: Document DigestInputStream behavior when skip() or mark() / reset() is used
  • a1df2da: 8292632: compiler/sharedstubs/SharedTrampolineTest.java fails with "Error: VM option 'PrintRelocations' is develop and is available only in debug version of VM."
  • 1b756bf: 8236048: Cleanup use of Utils.normalizeNewlines
  • 97e2689: 8288121: [JVMCI] Re-export the TerminatingThreadLocal functionality to the graal compiler.
  • 833bf06: 8292608: [AIX] Broken build after 8291945
  • ... and 3 more: https://git.openjdk.org/jdk/compare/d00e7b92b4a6d33f5db6e2aedce5e058832a23de...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 19, 2022
@openjdk openjdk bot closed this Aug 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@albertnetymk Pushed as commit 63a126a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the cardtable-remove-unused branch August 19, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
2 participants