8292682: Code change of JDK-8282730 not updated to reflect CSR update

[wangweij]

The final version of the CSR at https://bugs.openjdk.org/browse/JDK-8290119 uses @implNote for the new text, but the code change was not updated before the integration.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292682: Code change of JDK-8282730 not updated to reflect CSR update

Reviewers

• Xue-Lei Andrew Fan (@XueleiFan - Reviewer)
• Hai-May Chao (@haimaychao - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9949/head:pull/9949
$ git checkout pull/9949

Update a local copy of the PR:
$ git checkout pull/9949
$ git pull https://git.openjdk.org/jdk pull/9949/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9949

View PR using the GUI difftool:
$ git pr show -t 9949

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9949.diff

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a9e08c38)

[XueleiFan]

Per the CSR, this is a straightforward update to me.

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292682: Code change of JDK-8282730 not updated to reflect CSR update

Reviewed-by: xuelei, hchao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

• 57aac2a: 8290981: Enable CDS for zero builds
• 6a8a531: 8292564: x86: Remove redundant casts in Assembler usages
• 7244dd6: 8292267: Clean up synchronizer.hpp
• 1f3578b: 8292446: Make TableRateStatistics optional in CHT
• 45dec48: 8292592: JFR test TestNative is not reliable due to low rate of sampling.
• 58aae34: 8292576: Improve wording of AccessFlag-related specs
• 5ca268c: 8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID
• 37aa7c1: 8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers
• f2f0cd8: 8292511: AArch64: Align CPU feature name for NEON with hwcap
• 1f484da: 8289562: Change bugs.java.com and bugreport.java.com URL's to https
• ... and 41 more: https://git.openjdk.org/jdk/compare/3e122419b2979235f57c0dd549ca63647ea73753...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[haimaychao]

Looks good.

[wangweij]

/integrate

[openjdk]

Going to push as commit 74d3330.
Since your change was applied there have been 51 commits pushed to the master branch:

• 57aac2a: 8290981: Enable CDS for zero builds
• 6a8a531: 8292564: x86: Remove redundant casts in Assembler usages
• 7244dd6: 8292267: Clean up synchronizer.hpp
• 1f3578b: 8292446: Make TableRateStatistics optional in CHT
• 45dec48: 8292592: JFR test TestNative is not reliable due to low rate of sampling.
• 58aae34: 8292576: Improve wording of AccessFlag-related specs
• 5ca268c: 8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID
• 37aa7c1: 8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers
• f2f0cd8: 8292511: AArch64: Align CPU feature name for NEON with hwcap
• 1f484da: 8289562: Change bugs.java.com and bugreport.java.com URL's to https
• ... and 41 more: https://git.openjdk.org/jdk/compare/3e122419b2979235f57c0dd549ca63647ea73753...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit 74d3330.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.