8292686: runtime/cds/appcds/TestWithProfiler.java SIGSEGV in TableStatistics ctr

[coleenp]

There were two ConcurrentHashTable constructors that needed the non-default value of true in order to allocate TableRateStatistics in SymbolTable and StringTable, so I added them. Default parameters are dangerous. This is a trivial fix.
Tested tier 1-3 in progress. Tested with failed test and JFR tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292686: runtime/cds/appcds/TestWithProfiler.java SIGSEGV in TableStatistics ctr

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9952/head:pull/9952
$ git checkout pull/9952

Update a local copy of the PR:
$ git checkout pull/9952
$ git pull https://git.openjdk.org/jdk pull/9952/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9952

View PR using the GUI difftool:
$ git pr show -t 9952

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9952.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (75d2cf1a)

[dcubed-ojdk]

Thumbs up. This is a trivial fix.

[hseigel]

Looks good and trivial.
Thanks, Harold

[coleenp]

Thanks Dan and Harold!
/integrate

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292686: runtime/cds/appcds/TestWithProfiler.java SIGSEGV in TableStatistics ctr

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 235151e: 8292676: Remove two kerberos tests from problem list
• df5209e: 8292683: Remove BadKeyUsageTest.java from Problem List
• 74d3330: 8292682: Code change of JDK-8282730 not updated to reflect CSR update

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

Going to push as commit 07c9ba7.
Since your change was applied there have been 3 commits pushed to the master branch:

• 235151e: 8292676: Remove two kerberos tests from problem list
• df5209e: 8292683: Remove BadKeyUsageTest.java from Problem List
• 74d3330: 8292682: Code change of JDK-8282730 not updated to reflect CSR update

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 07c9ba7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.