New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292716: Configure should check that jtreg is of the required version #9965
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
Webrevs
|
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout jtreg-version-check
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
Don't forget to bump the required version of jtreg before integrating. |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 486f90c.
Your commit was automatically rebased without conflicts. |
While reviewing the PR for JDK-8289798 (switching to jtreg 7) I realized that it would be better if configure checked if the provided jtreg is of the minimum required version.
This PR is dependent on #9964, so what you see here is a diff relative to that PR, and it can't be merged until that PR has been merged.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9965/head:pull/9965
$ git checkout pull/9965
Update a local copy of the PR:
$ git checkout pull/9965
$ git pull https://git.openjdk.org/jdk pull/9965/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9965
View PR using the GUI difftool:
$ git pr show -t 9965
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9965.diff