Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292864: Remove resourceHash.hpp from header files #9999

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Aug 24, 2022

Please review this other trivial change to remove unneeded header files. Tested with cross compile other platforms and tier1 on Oracle platforms (x86, aarch64).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292864: Remove resourceHash.hpp from header files

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9999/head:pull/9999
$ git checkout pull/9999

Update a local copy of the PR:
$ git checkout pull/9999
$ git pull https://git.openjdk.org/jdk pull/9999/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9999

View PR using the GUI difftool:
$ git pr show -t 9999

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9999.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2022

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 24, 2022
@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Aug 24, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292864: Remove resourceHash.hpp from header files

Reviewed-by: stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • b653b9c: 8291969: Convert LoaderConstraintsTable to ResourceHashtable

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 24, 2022
@coleenp
Copy link
Contributor Author

coleenp commented Aug 24, 2022

Thanks Stefan!
/integrate

@openjdk
Copy link

openjdk bot commented Aug 24, 2022

Going to push as commit d3fed12.
Since your change was applied there has been 1 commit pushed to the master branch:

  • b653b9c: 8291969: Convert LoaderConstraintsTable to ResourceHashtable

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 24, 2022
@openjdk openjdk bot closed this Aug 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2022
@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@coleenp Pushed as commit d3fed12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the headers branch August 24, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants