Skip to content

Commit

Permalink
8259267: Refactor LoaderLeak shell test as java test.
Browse files Browse the repository at this point in the history
8225648: [TESTBUG] java/lang/annotation/loaderLeak/Main.java fails with -Xcomp

Reviewed-by: mdoerr
Backport-of: 75aa154
  • Loading branch information
RealCLanger committed Dec 14, 2022
1 parent e5c800c commit 7d50d51
Show file tree
Hide file tree
Showing 6 changed files with 137 additions and 304 deletions.
137 changes: 137 additions & 0 deletions test/jdk/java/lang/annotation/LoaderLeakTest.java
@@ -0,0 +1,137 @@
/*
* Copyright (c) 2004, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @bug 5040740
* @summary annotations cause memory leak
* @library /test/lib
* @build jdk.test.lib.process.*
* @run testng LoaderLeakTest
*/

import jdk.test.lib.Utils;
import jdk.test.lib.process.ProcessTools;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;
import java.io.FileInputStream;
import java.lang.annotation.Retention;
import java.lang.ref.Reference;
import java.lang.ref.WeakReference;
import java.nio.file.*;
import java.util.*;
import static java.lang.annotation.RetentionPolicy.RUNTIME;

public class LoaderLeakTest {

@Test
public void testWithoutReadingAnnotations() throws Throwable {
runJavaProcessExpectSuccessExitCode("Main");
}

@Test
public void testWithReadingAnnotations() throws Throwable {
runJavaProcessExpectSuccessExitCode("Main", "foo");
}

private void runJavaProcessExpectSuccessExitCode(String ... command) throws Throwable {
var processBuilder = ProcessTools.createJavaProcessBuilder(command)
.directory(Paths.get(Utils.TEST_CLASSES).toFile());
ProcessTools.executeCommand(processBuilder).shouldHaveExitValue(0);
}

}

class Main {

public static void main(String[] args) throws Exception {
for (int i = 0; i < 100; i++) {
doTest(args.length != 0);
}
}

static void doTest(boolean readAnn) throws Exception {
ClassLoader loader = new SimpleClassLoader();
var c = new WeakReference<Class<?>>(loader.loadClass("C"));
if (c.get() == null) throw new AssertionError("class missing after loadClass");
// c.get() should never return null here since we hold a strong
// reference to the class loader that loaded the class referred by c.
if (c.get().getClassLoader() != loader) throw new AssertionError("wrong classloader");
if (readAnn) System.out.println(c.get().getAnnotations()[0]);
if (c.get() == null) throw new AssertionError("class missing before GC");
System.gc();
System.gc();
if (c.get() == null) throw new AssertionError("class missing after GC but before loader is unreachable");
System.gc();
System.gc();
Reference.reachabilityFence(loader);
loader = null;

// Might require multiple calls to System.gc() for weak-references
// processing to be complete. If the weak-reference is not cleared as
// expected we will hang here until timed out by the test harness.
while (true) {
System.gc();
Thread.sleep(20);
if (c.get() == null) {
break;
}
}
}
}

@Retention(RUNTIME)
@interface A {
B b();
}

@interface B { }

@A(b=@B()) class C { }

class SimpleClassLoader extends ClassLoader {
public SimpleClassLoader() { }

private byte[] getClassImplFromDataBase(String className) {
try {
return Files.readAllBytes(Paths.get(className + ".class"));
} catch (Exception e) {
throw new Error("could not load class " + className, e);
}
}

@Override
public Class<?> loadClass(String className, boolean resolveIt)
throws ClassNotFoundException {
switch (className) {
case "A":
case "B":
case "C": {
var classData = getClassImplFromDataBase(className);
return defineClass(className, classData, 0, classData.length);
}
}
return super.loadClass(className, resolveIt);
}

}
28 changes: 0 additions & 28 deletions test/jdk/java/lang/annotation/loaderLeak/A.java

This file was deleted.

24 changes: 0 additions & 24 deletions test/jdk/java/lang/annotation/loaderLeak/B.java

This file was deleted.

24 changes: 0 additions & 24 deletions test/jdk/java/lang/annotation/loaderLeak/C.java

This file was deleted.

93 changes: 0 additions & 93 deletions test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh

This file was deleted.

1 comment on commit 7d50d51

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.