Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8212904: JTextArea line wrapping incorrect when using UI scale #1143

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 10, 2022

Hi all,
This pull request contains a backport of commit 702ee3db from the openjdk/jdk repository.
The commit being backported was authored by Prasanta Sadhukhan on 29 Mar 2019 and was reviewed by Sergey Bylokhov and Phil Race.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8212904: JTextArea line wrapping incorrect when using UI scale

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1143/head:pull/1143
$ git checkout pull/1143

Update a local copy of the PR:
$ git checkout pull/1143
$ git pull https://git.openjdk.org/jdk11u-dev pull/1143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1143

View PR using the GUI difftool:
$ git pr show -t 1143

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1143.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 702ee3db37a130f4729062e72880446131946a12 8212904: JTextArea line wrapping incorrect when using UI scale Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8212904: JTextArea line wrapping incorrect when using UI scale

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 10, 2022
@mrserb mrserb marked this pull request as ready for review June 10, 2022 23:11
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Jun 20, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 20, 2022

Going to push as commit 246f48e.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 684f12e: 8283849: AsyncGetCallTrace may crash JVM on guarantee
  • 8e94c68: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • ffd8dc2: 8225122: Test AncestorResized.java fails when Windows desktop is scaled.
  • 538794f: Merge
  • 1dd942d: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
  • c64f12c: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4
  • 2632f54: 8287109: Distrust.java failed with CertificateExpiredException
  • 68f6fbb: 8284754: print more interesting env variables in hs_err and VM.info
  • 372af6a: 8266490: Extend the OSContainer API to support the pids controller of cgroups

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 20, 2022
@openjdk openjdk bot closed this Jun 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2022
@openjdk
Copy link

openjdk bot commented Jun 20, 2022

@mrserb Pushed as commit 246f48e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant