Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278519: serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java failed "assert(handle != __null) failed: JNI handle should not be null" #1167

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 21, 2022

I backport this for parity with 11.0.17-oracle.

Clean except for Copyright. Will mark clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278519: serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java failed "assert(handle != __null) failed: JNI handle should not be null"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1167/head:pull/1167
$ git checkout pull/1167

Update a local copy of the PR:
$ git checkout pull/1167
$ git pull https://git.openjdk.org/jdk11u-dev pull/1167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1167

View PR using the GUI difftool:
$ git pr show -t 1167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1167.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 63e43030ed1260d14df950342c39a377231a3f40 8278519: serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java failed "assert(handle != __null) failed: JNI handle should not be null" Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 21, 2022

/clean

@openjdk openjdk bot added the clean label Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8278519: serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java failed "assert(handle != __null) failed: JNI handle should not be null"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 24, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 24, 2022

Going to push as commit 6c389cd.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 43e6fdb: 8281569: Create tests for Frame.setMinimumSize() method
  • f129738: 8288754: GCC 12 fails to build zReferenceProcessor.cpp
  • e16aaca: 8253829: Wrong length compared in SSPI bridge
  • 1c1f7a1: 8210722: JAXP Tests: CatalogSupport2 and CatalogSupport3 generate incorrect messages upon failure
  • 8138382: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
  • 4945cfe: 8164804: sun/security/ssl/SSLSocketImpl/CloseSocket.java makes not reliable time assumption
  • d12c2e2: 8217170: gc/arguments/TestUseCompressedOopsErgo.java timed out
  • c10e0de: 8272398: Update DockerTestUtils.buildJdkDockerImage()

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2022
@openjdk openjdk bot closed this Jun 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2022
@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@GoeLin Pushed as commit 6c389cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8278519 branch June 24, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant