Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274506: TestPids.java and TestPidsLimit.java fail with podman run as root #1186

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jun 24, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274506: TestPids.java and TestPidsLimit.java fail with podman run as root

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1186/head:pull/1186
$ git checkout pull/1186

Update a local copy of the PR:
$ git checkout pull/1186
$ git pull https://git.openjdk.org/jdk11u-dev pull/1186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1186

View PR using the GUI difftool:
$ git pr show -t 1186

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1186.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 94e31e5ca51d1c4c253cf7ac5acd950d10c22267 8274506: TestPids.java and TestPidsLimit.java fail with podman run as root Jun 24, 2022
@openjdk
Copy link

openjdk bot commented Jun 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274506: TestPids.java and TestPidsLimit.java fail with podman run as root

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2022

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

Going to push as commit d7b6f7f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 1fbbd15: 8287366: Improve test failure reporting in GHA
  • 8363d9d: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2022
@openjdk openjdk bot closed this Jun 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@MBaesken Pushed as commit d7b6f7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant