Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287432: C2: assert(tn->in(0) != __null) failed: must have live top node #1190

Closed
wants to merge 1 commit into from

Conversation

theRealAph
Copy link
Contributor

@theRealAph theRealAph commented Jun 30, 2022

Trivial backport, fixes the test case.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287432: C2: assert(tn->in(0) != __null) failed: must have live top node

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1190/head:pull/1190
$ git checkout pull/1190

Update a local copy of the PR:
$ git checkout pull/1190
$ git pull https://git.openjdk.org/jdk11u-dev pull/1190/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1190

View PR using the GUI difftool:
$ git pr show -t 1190

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1190.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2022

👋 Welcome back aph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 78d371266ae8a629db8176ced4d48e9521702cce 8287432: C2: assert(tn->in(0) != __null) failed: must have live top node Jun 30, 2022
@openjdk
Copy link

openjdk bot commented Jun 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 30, 2022

@theRealAph This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287432: C2: assert(tn->in(0) != __null) failed: must have live top node

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 112 new commits pushed to the master branch:

  • c53e0fe: 8288467: remove memory_operand assert for spilled instructions
  • c6e2a5b: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc
  • 87bcc4e: 8284882: SIGSEGV in Node::verify_edges due to compilation bailout
  • fb76f0e: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
  • 6fe8d8d: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null
  • b4f0859: 8285398: Cache the results of constraint checks
  • eb8789b: 8284694: Avoid evaluating SSLAlgorithmConstraints twice
  • 97178bf: 8282214: Upgrade JQuery to version 3.6.0
  • 027302b: 8284680: sun.font.FontConfigManager.getFontConfig() leaks charset
  • ab7d1ca: 8284956: Potential leak awtImageData/color_data when initializes X11GraphicsEnvironment
  • ... and 102 more: https://git.openjdk.org/jdk11u-dev/compare/df88e3de5e890b402be16293b7bf5df0fb0b107b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2022

Webrevs

@devinrsmith
Copy link

Thanks for the work @theRealAph. I'm assuming this can land for 11.0.16?

@GoeLin
Copy link
Member

GoeLin commented Jul 21, 2022

@theRealAph, would you mind integrating this? Thanks!

@theRealAph
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 2, 2022

Going to push as commit 954d57a.
Since your change was applied there have been 216 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 2, 2022
@openjdk openjdk bot closed this Aug 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2022
@openjdk
Copy link

openjdk bot commented Aug 2, 2022

@theRealAph Pushed as commit 954d57a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants