New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8284367: JQuery UI upgrade from 1.12.1 to 1.13.1 #1198
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 0174134.
Your commit was automatically rebased without conflicts. |
I backported this from 17.
After replacing script-dir with jquery in the file paths of the patch it
applies somehow. Still, the following adaptions were needed:
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java
Context: jszip files are not in the list in 17.
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css
Add ".ui-autocomplete .result-item {...}".
Please review this carefully.
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/DocPaths.java
I added JQUERY_UI_STRUCTURE_CSS by hand. The context contains JSZIP paths that are not in 17.
test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java
test/langtools/jdk/javadoc/tool/api/basic/APITest.java
Again, jszip files in the context.
Added edits also to test/langtools/tools/javadoc/api/basic/APITest.java
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1198/head:pull/1198
$ git checkout pull/1198
Update a local copy of the PR:
$ git checkout pull/1198
$ git pull https://git.openjdk.org/jdk11u-dev pull/1198/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1198
View PR using the GUI difftool:
$ git pr show -t 1198
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1198.diff