8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java

[shruacha1234]

OpenJDK PR : openjdk/jdk#9369
OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8289471

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1273/head:pull/1273
$ git checkout pull/1273

Update a local copy of the PR:
$ git checkout pull/1273
$ git pull https://git.openjdk.org/jdk11u-dev pull/1273/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1273

View PR using the GUI difftool:
$ git pr show -t 1273

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1273.diff

[bridgekeeper]

👋 Welcome back shruacha1234! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shruacha1234 this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout key_initialization_issue_backport_987656d
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk-notifier]

@shruacha1234 Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (af3752c0)

[shruacha1234]

@RealCLanger Can you please review this PR

[phohensee]

Looks clean, lgtm.

[openjdk]

@shruacha1234 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 8871303: 8282933: Create a test for JDK-4529616
• 1ab3f82: 8283507: Create a regression test for RFE 4287690
• 1533520: 8283621: Write a regression test for CCC4400728
• b235f51: 8283623: Create an automated regression test for JDK-4525475
• 5a0824b: 8269039: Disable SHA-1 Signed JARs
• 5f79e3b: 8290334: Update FreeType to 2.12.1
• 60a6890: 8290246: test fails "assert(init != __null) failed: initialization not found"
• 8a88a69: 8286314: Trampoline not created for far runtime targets outside small CodeCache
• 81ffdc1: 8283015: Create a test for JDK-4715496
• fc4868e: 8283493: Create an automated regression test for RFE 4231298
• ... and 13 more: https://git.openjdk.org/jdk11u-dev/compare/37ca256b782ac4793e30edb18edadf64de562ea5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[shruacha1234]

/integrate

[openjdk]

@shruacha1234
Your change (at version af3752c) is now ready to be sponsored by a Committer.

[RealCLanger]

Same here: Before integration, this needs maintainer approval. See point 6 of the Wiki. @phohensee ?

[phohensee]

Tagged and commented on the JBS issue.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 1c96cac.
Since your change was applied there have been 32 commits pushed to the master branch:

• ac89673: 8290000: Bump macOS GitHub actions to macOS 11
• d647021: 8283624: Create an automated regression test for RFE-4390885
• 9796aac: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues
• 3210c99: 8283245: Create a test for JDK-4670319
• 7318cdc: 8221871: javadoc should not set role=region on
  elements
• 93666ae: 8218413: make reconfigure ignores configure-time AUTOCONF environment variable
• 954d57a: 8287432: C2: assert(tn->in(0) != __null) failed: must have live top node
• 9cf9879: 8267880: Upgrade the default PKCS12 MAC algorithm
• e80c7e1: 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available
• 8871303: 8282933: Create a test for JDK-4529616
• ... and 22 more: https://git.openjdk.org/jdk11u-dev/compare/37ca256b782ac4793e30edb18edadf64de562ea5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @shruacha1234 Pushed as commit 1c96cac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.