New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8251152: ARM32: jtreg c2 Test8202414 test crash #1321
Conversation
👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@caojoshua This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
JBS issue tagged. |
Again, please rename to |
This backport pull request has now been updated with issue and summary from the original commit. |
/integrate |
@caojoshua |
/sponsor Got the approval. |
Going to push as commit ad2e6e4.
Your commit was automatically rebased without conflicts. |
@phohensee @caojoshua Pushed as commit ad2e6e4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of 8251152: ARM32: jtreg c2 Test8202414 test crash
Backport is not clean because JDK 11 does not include JDK-8244224.
The patch removed the
@requires
line, but the line is present in JDK 11.Manual fix is trivial. We just paste the new lines under the
@requires
lineProgress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1321/head:pull/1321
$ git checkout pull/1321
Update a local copy of the PR:
$ git checkout pull/1321
$ git pull https://git.openjdk.org/jdk11u-dev pull/1321/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1321
View PR using the GUI difftool:
$ git pr show -t 1321
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1321.diff