Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283903: GetContainerCpuLoad does not return the correct result in share mode #1332

Closed
wants to merge 1 commit into from

Conversation

xpbob
Copy link

@xpbob xpbob commented Aug 18, 2022

Backport a625bfdba45d49bc717bcc9be4112db93b50f50a


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283903: GetContainerCpuLoad does not return the correct result in share mode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1332/head:pull/1332
$ git checkout pull/1332

Update a local copy of the PR:
$ git checkout pull/1332
$ git pull https://git.openjdk.org/jdk11u-dev pull/1332/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1332

View PR using the GUI difftool:
$ git pr show -t 1332

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1332.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2022

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a625bfdba45d49bc717bcc9be4112db93b50f50a 8283903: GetContainerCpuLoad does not return the correct result in share mode Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 18, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2022

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport can be considered clean, just copyright diff.

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@xpbob This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283903: GetContainerCpuLoad does not return the correct result in share mode

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 76cab61: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4
  • a491f0d: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl
  • fa8c0d6: 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64
  • 501352c: 8239423: jdk/jfr/jvm/TestJFRIntrinsic.java failed with -XX:-TieredCompilation
  • a77dd69: 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package
  • ad2e6e4: 8251152: ARM32: jtreg c2 Test8202414 test crash
  • 58076db: 8214078: (fs) SecureDirectoryStream not supported on arm32
  • 3db29c4: 8252145: Unify Info.plist files with correct version strings

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 18, 2022
@xpbob
Copy link
Author

xpbob commented Aug 19, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@xpbob
Your change (at version 383cf22) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

Going to push as commit 42dc282.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 76cab61: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4
  • a491f0d: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl
  • fa8c0d6: 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64
  • 501352c: 8239423: jdk/jfr/jvm/TestJFRIntrinsic.java failed with -XX:-TieredCompilation
  • a77dd69: 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package
  • ad2e6e4: 8251152: ARM32: jtreg c2 Test8202414 test crash
  • 58076db: 8214078: (fs) SecureDirectoryStream not supported on arm32
  • 3db29c4: 8252145: Unify Info.plist files with correct version strings

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 19, 2022
@openjdk openjdk bot closed this Aug 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@DamonFool @xpbob Pushed as commit 42dc282.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants