8287463: JFR: Disable TestDevNull.java on Windows #1347
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to backport JDK-8287463 to 11u.
This test-only fix disables jdk/jfr/api/recording/dump/TestDumpDevNull.java test on Windows.
Without this fix the test fails with "java.nio.file.NoSuchFileException: \dev\null".
The test is added by JDK-8282947 which is already backported to 11u.
The patch applies cleanly.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1347/head:pull/1347
$ git checkout pull/1347
Update a local copy of the PR:
$ git checkout pull/1347
$ git pull https://git.openjdk.org/jdk11u-dev pull/1347/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1347
View PR using the GUI difftool:
$ git pr show -t 1347
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1347.diff