Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287463: JFR: Disable TestDevNull.java on Windows #1347

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link

@kvergizova kvergizova commented Aug 30, 2022

I'd like to backport JDK-8287463 to 11u.
This test-only fix disables jdk/jfr/api/recording/dump/TestDumpDevNull.java test on Windows.
Without this fix the test fails with "java.nio.file.NoSuchFileException: \dev\null".
The test is added by JDK-8282947 which is already backported to 11u.
The patch applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287463: JFR: Disable TestDevNull.java on Windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1347/head:pull/1347
$ git checkout pull/1347

Update a local copy of the PR:
$ git checkout pull/1347
$ git pull https://git.openjdk.org/jdk11u-dev pull/1347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1347

View PR using the GUI difftool:
$ git pr show -t 1347

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1347.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2022

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0df4748216ab71937cfcfb86a2d66f3568bced1e 8287463: JFR: Disable TestDevNull.java on Windows Aug 30, 2022
@openjdk
Copy link

openjdk bot commented Aug 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 30, 2022

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287463: JFR: Disable TestDevNull.java on Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2022

Webrevs

@kvergizova
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 30, 2022

Going to push as commit 9186b3c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 30, 2022
@openjdk openjdk bot closed this Aug 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2022
@openjdk
Copy link

openjdk bot commented Aug 30, 2022

@kvergizova Pushed as commit 9186b3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8287463 branch February 16, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant