Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening #1350

Closed
wants to merge 1 commit into from

Conversation

rccha
Copy link

@rccha rccha commented Aug 31, 2022

Backport for JDK-8274563


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1350/head:pull/1350
$ git checkout pull/1350

Update a local copy of the PR:
$ git checkout pull/1350
$ git pull https://git.openjdk.org/jdk11u-dev pull/1350/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1350

View PR using the GUI difftool:
$ git pr show -t 1350

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1350.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Aug 31, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2022

Hi @rccha, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user rccha" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk openjdk bot changed the title Backport 47bfc8aa9367ff852ea5d901f1fa3c6ef316913e 8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening Aug 31, 2022
@openjdk
Copy link

openjdk bot commented Aug 31, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 31, 2022
@phohensee
Copy link
Member

I can verify that Ruhesh is an Amazon employee and therefore covered under the OCA.

@rccha
Copy link
Author

rccha commented Sep 2, 2022

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Sep 2, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2022

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Sep 7, 2022
@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@rccha This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 0dc1035: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked
  • 09fe47f: 8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output
  • 9767c4c: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
  • c249ca9: 8268893: jcmd to trim the glibc heap
  • 0ba5a81: 8276841: Add support for Visual Studio 2022
  • 131eab6: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
  • f75b74d: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider
  • 78ba1e5: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
  • 2548ed3: 8242468: VS2019 build missing vcruntime140_1.dll
  • 75b3e45: 8239708: Split basics.m4 into basic.m4 and util.m4
  • ... and 5 more: https://git.openjdk.org/jdk11u-dev/compare/c9f313574a20ef8069c2028d85d003f7b9c49b05...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2022

Webrevs

@phohensee
Copy link
Member

JBS issue tagged. A 17u backport would be a good idea.

@RealCLanger
Copy link
Contributor

JBS issue tagged. A 17u backport would be a good idea.

Definitely. Please do 17u before 11u.

@rccha
Copy link
Author

rccha commented Sep 14, 2022

/integrate

@phohensee
Copy link
Member

/sponsor

17u backport done, got the approval.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 14, 2022
@openjdk
Copy link

openjdk bot commented Sep 14, 2022

@rccha
Your change (at version 2dc7deb) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Sep 14, 2022

Going to push as commit 6784ea0.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 0dc1035: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked
  • 09fe47f: 8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output
  • 9767c4c: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
  • c249ca9: 8268893: jcmd to trim the glibc heap
  • 0ba5a81: 8276841: Add support for Visual Studio 2022
  • 131eab6: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
  • f75b74d: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider
  • 78ba1e5: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
  • 2548ed3: 8242468: VS2019 build missing vcruntime140_1.dll
  • 75b3e45: 8239708: Split basics.m4 into basic.m4 and util.m4
  • ... and 5 more: https://git.openjdk.org/jdk11u-dev/compare/c9f313574a20ef8069c2028d85d003f7b9c49b05...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 14, 2022
@openjdk openjdk bot closed this Sep 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 14, 2022
@openjdk
Copy link

openjdk bot commented Sep 14, 2022

@phohensee @rccha Pushed as commit 6784ea0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants