Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293202: Document how to edit doc/testing, doc/building #1353

Conversation

LudwikJaniuk
Copy link

@LudwikJaniuk LudwikJaniuk commented Sep 2, 2022

Hi all,

This pull request contains a backport of commit 7c2f2994 from the openjdk/jdk repository.

The commit being backported was authored by Ludvig Janiuk on 1 Sep 2022 and was reviewed by Erik Joelsson.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293202: Document how to edit doc/testing, doc/building

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1353/head:pull/1353
$ git checkout pull/1353

Update a local copy of the PR:
$ git checkout pull/1353
$ git pull https://git.openjdk.org/jdk11u-dev pull/1353/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1353

View PR using the GUI difftool:
$ git pr show -t 1353

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1353.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2022

👋 Welcome back lujaniuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7c2f2994da1577152870eaf2ea71dfba470c29ef 8293202: Document how to edit doc/testing, doc/building Sep 2, 2022
@openjdk
Copy link

openjdk bot commented Sep 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 2, 2022

@LudwikJaniuk This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293202: Document how to edit doc/testing, doc/building

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • 0013d84: 8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS
  • b8bc720: 8282857: Create a regression test for JDK-4702690
  • f8e71f8: 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode
  • 905baaf: 8290451: Incorrect result when switching to C2 OSR compilation from C1
  • 49b85e8: 8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)
  • fba01e8: 8290705: StringConcat::validate_mem_flow asserts with "unexpected user: StoreI"
  • 0f84f99: 8282276: Problem list failing two Robot Screen Capture tests
  • fb9a279: 8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses
  • 66d4be3: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305
  • ca33f6c: 8293578: Duplicate ldc generated by javac
  • ... and 29 more: https://git.openjdk.org/jdk11u-dev/compare/78ba1e5a5f69909ddf073cb014784127b09dd47d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 2, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2022

Webrevs

@LudwikJaniuk
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 5, 2022
@openjdk
Copy link

openjdk bot commented Sep 5, 2022

@LudwikJaniuk
Your change (at version 600bb49) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

Hi @LudwikJaniuk,
although the patch applies clean, you have to request backport approval in OpenJDK update releases by adding the jdk11u-fix-request label to the JBS bug and adding a comment on why you want to backport it and how you tested it. Please see this wiki for more details.
If you want to get it into JDK11 Updates, I suggest you backport it to JDK17u and JDK19u first.
Thanks

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2022

@LudwikJaniuk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2022

@LudwikJaniuk This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
Development

Successfully merging this pull request may close these issues.

None yet

2 participants