New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268893: jcmd to trim the glibc heap #1354
Conversation
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Pinging @RealCLanger (Need JBS Approval to) |
@tstuefe This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Merci! /integrate |
Going to push as commit c249ca9.
Your commit was automatically rebased without conflicts. |
Backport the System.trim_native_heap command to 11.
This needs a CSR backport, which exists, it was approved for 11 ages ago (https://bugs.openjdk.org/browse/JDK-8273602) but then the actual backport fell under the table.
The downport is not clean. Since 8282382 had been downported selectively, which introduced
print_glibc_malloc_tunables
to os_linux.cpp, which sits smack in the middle of the code to change. The hunk affected breaks out the proc-file-reading from the oldos::Linux::print_process_memory_info()
intoos::Linux::query_process_memory_info()
- with this patch, both functions are identical now between jdk11u and later releases even though the diff looks different.Patch was tested in GHAs, and I ran manual tests with
jcmd .. System.trim_native_heap
, all works.Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1354/head:pull/1354
$ git checkout pull/1354
Update a local copy of the PR:
$ git checkout pull/1354
$ git pull https://git.openjdk.org/jdk11u-dev pull/1354/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1354
View PR using the GUI difftool:
$ git pr show -t 1354
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1354.diff