Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269029: compiler/codegen/TestCharVect2.java fails for client VMs #1357

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 15, 2022

Simple resolve, original change has an additional arg in the context lines.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269029: compiler/codegen/TestCharVect2.java fails for client VMs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1357/head:pull/1357
$ git checkout pull/1357

Update a local copy of the PR:
$ git checkout pull/1357
$ git pull https://git.openjdk.org/jdk11u-dev pull/1357/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1357

View PR using the GUI difftool:
$ git pr show -t 1357

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1357.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cbec37d45d77533081c27b3fc649098dfcca0425 8269029: compiler/codegen/TestCharVect2.java fails for client VMs Sep 15, 2022
@openjdk
Copy link

openjdk bot commented Sep 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 15, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8269029: compiler/codegen/TestCharVect2.java fails for client VMs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 307 new commits pushed to the master branch:

  • 6784ea0: 8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening
  • 0dc1035: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked
  • 09fe47f: 8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output
  • 9767c4c: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
  • c249ca9: 8268893: jcmd to trim the glibc heap
  • 0ba5a81: 8276841: Add support for Visual Studio 2022
  • 131eab6: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
  • f75b74d: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider
  • 78ba1e5: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
  • 2548ed3: 8242468: VS2019 build missing vcruntime140_1.dll
  • ... and 297 more: https://git.openjdk.org/jdk11u-dev/compare/bf3438c5dc993b96d089cabb5318bfc64a6904a3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Sep 16, 2022

Pre-submit tests: MineField.sh fails, I saw this in several runs lately. Unrelated

@GoeLin
Copy link
Member Author

GoeLin commented Sep 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2022

Going to push as commit 6d30812.
Since your change was applied there have been 307 commits pushed to the master branch:

  • 6784ea0: 8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening
  • 0dc1035: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked
  • 09fe47f: 8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output
  • 9767c4c: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
  • c249ca9: 8268893: jcmd to trim the glibc heap
  • 0ba5a81: 8276841: Add support for Visual Studio 2022
  • 131eab6: 8292541: [Metrics] Reported memory limit may exceed physical machine memory
  • f75b74d: 6782021: It is not possible to read local computer certificates with the SunMSCAPI provider
  • 78ba1e5: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
  • 2548ed3: 8242468: VS2019 build missing vcruntime140_1.dll
  • ... and 297 more: https://git.openjdk.org/jdk11u-dev/compare/bf3438c5dc993b96d089cabb5318bfc64a6904a3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 16, 2022
@openjdk openjdk bot closed this Sep 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2022
@openjdk
Copy link

openjdk bot commented Sep 16, 2022

@GoeLin Pushed as commit 6d30812.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8269029 branch September 16, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant