Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses #1382

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Oct 2, 2022

Backport of JDK-8290781 for 11u.

Fixes a crash during C2 compilation. The fix is low risk and applies cleanly. Already tested and backported to JDK 19u, Oracle JDK 11u and 17u.

Tested by

  • running jtreg tier1, tier2, jck runtime on linux x64, x86, aarch64
  • manually ran test from the JBS description with specified parameters.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1382/head:pull/1382
$ git checkout pull/1382

Update a local copy of the PR:
$ git checkout pull/1382
$ git pull https://git.openjdk.org/jdk11u-dev pull/1382/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1382

View PR using the GUI difftool:
$ git pr show -t 1382

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1382.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4c90e87a6fa83a66fdb8767b999879600629f1f6 8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses Oct 2, 2022
@openjdk
Copy link

openjdk bot commented Oct 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 2, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 66d4be3: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305
  • ca33f6c: 8293578: Duplicate ldc generated by javac

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 2, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2022

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 4, 2022
@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@Rudometov
Your change (at version 03ddcb1) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 4, 2022

Going to push as commit fb9a279.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 66d4be3: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305
  • ca33f6c: 8293578: Duplicate ldc generated by javac

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2022
@openjdk openjdk bot closed this Oct 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 4, 2022
@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@phohensee @Rudometov Pushed as commit fb9a279.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants