Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS #1392

Closed
wants to merge 1 commit into from

Conversation

caojoshua
Copy link
Contributor

@caojoshua caojoshua commented Oct 5, 2022

Not a clean backport:

  • conflict in copyright year
  • removing the test from ProblemList.txt is not clean because surrounding lines are different

Passes NullModalityDialogTest.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1392/head:pull/1392
$ git checkout pull/1392

Update a local copy of the PR:
$ git checkout pull/1392
$ git pull https://git.openjdk.org/jdk11u-dev pull/1392/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1392

View PR using the GUI difftool:
$ git pr show -t 1392

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1392.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2022

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2b5869ad09e8f34277a4c965abbaed3f79fc5b59 8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS Oct 5, 2022
@openjdk
Copy link

openjdk bot commented Oct 5, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 5, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 5, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Oct 5, 2022

@caojoshua This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@phohensee
Copy link
Member

Tagged JBS issue.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 5, 2022
@caojoshua
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 6, 2022
@openjdk
Copy link

openjdk bot commented Oct 6, 2022

@caojoshua
Your change (at version e7a364c) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 6, 2022

Going to push as commit 0013d84.
Since your change was applied there has been 1 commit pushed to the master branch:

  • b8bc720: 8282857: Create a regression test for JDK-4702690

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 6, 2022
@openjdk openjdk bot closed this Oct 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 6, 2022
@openjdk
Copy link

openjdk bot commented Oct 6, 2022

@phohensee @caojoshua Pushed as commit 0013d84.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants