-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows #1396
Conversation
👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@Rudometov This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@Rudometov |
/sponsor |
Going to push as commit 9ddc8b0.
Your commit was automatically rebased without conflicts. |
@phohensee @Rudometov Pushed as commit 9ddc8b0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport for https://bugs.openjdk.org/browse/JDK-6829250
Had to manually merge test/jdk/ProblemList.txt
The test test/jdk/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java cherry-pick clean.
Trivial test fix, parity with 11.0.18-oracle
Checked manually on Windows, test passes.
Pipelines with tier1, tier2 ok.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1396/head:pull/1396
$ git checkout pull/1396
Update a local copy of the PR:
$ git checkout pull/1396
$ git pull https://git.openjdk.org/jdk11u-dev pull/1396/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1396
View PR using the GUI difftool:
$ git pr show -t 1396
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1396.diff