Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows #1396

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Oct 7, 2022

Backport for https://bugs.openjdk.org/browse/JDK-6829250

Had to manually merge test/jdk/ProblemList.txt
The test test/jdk/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java cherry-pick clean.

Trivial test fix, parity with 11.0.18-oracle
Checked manually on Windows, test passes.
Pipelines with tier1, tier2 ok.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1396/head:pull/1396
$ git checkout pull/1396

Update a local copy of the PR:
$ git checkout pull/1396
$ git pull https://git.openjdk.org/jdk11u-dev pull/1396/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1396

View PR using the GUI difftool:
$ git pr show -t 1396

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1396.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f56396f1689ea7e13dea78dcb1d14dcce94da898 6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows Oct 7, 2022
@openjdk
Copy link

openjdk bot commented Oct 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 7, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 34b1178: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  • 18d8559: 8293816: CI: ciBytecodeStream::get_klass() is not consistent
  • 3622c42: 8293044: C1: Missing access check on non-accessible class
  • 094ca71: 8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points
  • 57c1b21: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails
  • df5f253: 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI
  • 3b9e482: 8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values
  • b6bf677: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field
  • a84c773: 8263326: Remove ReceiverTypeData check from serviceability/sa/TestPrintMdo.java
  • f7e6d0d: 8198343: Test java/awt/print/PrinterJob/TestPgfmtSetMPA.java may fail w/o printer
  • ... and 9 more: https://git.openjdk.org/jdk11u-dev/compare/f8e71f816bff24ac33c06d341b92fbe1244c4b74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2022

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@Rudometov
Your change (at version d58b6a5) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

Going to push as commit 9ddc8b0.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 34b1178: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  • 18d8559: 8293816: CI: ciBytecodeStream::get_klass() is not consistent
  • 3622c42: 8293044: C1: Missing access check on non-accessible class
  • 094ca71: 8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points
  • 57c1b21: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails
  • df5f253: 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI
  • 3b9e482: 8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values
  • b6bf677: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field
  • a84c773: 8263326: Remove ReceiverTypeData check from serviceability/sa/TestPrintMdo.java
  • f7e6d0d: 8198343: Test java/awt/print/PrinterJob/TestPgfmtSetMPA.java may fail w/o printer
  • ... and 9 more: https://git.openjdk.org/jdk11u-dev/compare/f8e71f816bff24ac33c06d341b92fbe1244c4b74...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2022
@openjdk openjdk bot closed this Oct 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@phohensee @Rudometov Pushed as commit 9ddc8b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the Backport-JDK-6829250 branch October 26, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants