Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282345: handle latest VS2022 in abstract_vm_version #1417

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 9, 2022

I backport this for parity with 11.0.18-oracle.

Clean except for copyright.
But I do not want to drop support for old compilers in this rather old release,
so I did not remove the corresponding code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282345: handle latest VS2022 in abstract_vm_version

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1417/head:pull/1417
$ git checkout pull/1417

Update a local copy of the PR:
$ git checkout pull/1417
$ git pull https://git.openjdk.org/jdk11u-dev pull/1417/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1417

View PR using the GUI difftool:
$ git pr show -t 1417

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1417.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 735e86b0f71c97c2ba35c1cffd9b4492a8ca55bc 8282345: handle latest VS2022 in abstract_vm_version Oct 9, 2022
@openjdk
Copy link

openjdk bot commented Oct 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 9, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2022

Webrevs

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, keeping the old VS2010/VS2012 makes sense for jdk11 .

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282345: handle latest VS2022 in abstract_vm_version

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • dde80ab: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • 380cbc8: 8284521: Write an automated regression test for RFE 4371575
  • a6fafe8: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java
  • 01d99fa: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • fbaf2f2: 8282640: Create a test for JDK-4740761
  • 01cc71f: 8284294: Create an automated regression test for RFE 4138746
  • 910546f: 8283422: Create a new test for JDK-8254790
  • 0910bdb: 8282046: Create a regression test for JDK-8000326
  • ec5041e: 8282936: Write a regression test for JDK-4615365
  • 5a3e86c: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
  • ... and 23 more: https://git.openjdk.org/jdk11u-dev/compare/9014a180dc9656099a89e597c4dba31a41b68ad1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Oct 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 12, 2022

Going to push as commit 1d9108f.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 81e900a: 8233557: [TESTBUG] DoubleClickTitleBarTest.java fails on macOs
  • 64a3b18: 8244010: Simplify usages of ProcessTools.createJavaProcessBuilder in our tests
  • 605e390: 8281296: Create a regression test for JDK-4515999
  • f67b4de: 8294357: (tz) Update Timezone Data to 2022d
  • 4566c88: 8233558: [TESTBUG] WindowOwnedByEmbeddedFrameTest.java fails on macos
  • 4be6963: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
  • dde80ab: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • 380cbc8: 8284521: Write an automated regression test for RFE 4371575
  • a6fafe8: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java
  • 01d99fa: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • ... and 29 more: https://git.openjdk.org/jdk11u-dev/compare/9014a180dc9656099a89e597c4dba31a41b68ad1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 12, 2022
@openjdk openjdk bot closed this Oct 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2022
@GoeLin GoeLin deleted the goetz_backport_8282345 branch October 12, 2022 09:03
@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@GoeLin Pushed as commit 1d9108f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants