Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test #1435

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 11, 2022

I backport this for parity with 11.0.18-oracle.

I had to replace a string text block by common string concatenation.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1435/head:pull/1435
$ git checkout pull/1435

Update a local copy of the PR:
$ git checkout pull/1435
$ git pull https://git.openjdk.org/jdk11u-dev pull/1435/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1435

View PR using the GUI difftool:
$ git pr show -t 1435

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1435.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e7c3b9de649d4b28ba16844e042afcf3c89323e5 8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 11, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 16a4bd3: 8288599: com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total swap size ... but getTotalSwapSpaceSize returned ...
  • 523ef55: 8282777: Create a Regression test for JDK-4515031
  • 957a888: 8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray
  • e864cfc: 8282778: Create a regression test for JDK-4699544
  • 74bc485: 8287091: aarch64 : guarantee(val < (1ULL << nbits)) failed: Field too big for insn
  • 31d178b: 8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)
  • c064dce: 8274597: Some of the dnd tests time out and fail intermittently
  • 9ffc4b3: 8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation
  • fb08d9d: 8282937: Write a regression test for JDK-4820080
  • 1d9108f: 8282345: handle latest VS2022 in abstract_vm_version
  • ... and 22 more: https://git.openjdk.org/jdk11u-dev/compare/9ddc8b02fa7632a3d4b8f24484a1ecbda3b247bc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Oct 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

Going to push as commit bc2d8cc.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 243a55e: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368
  • 58ac929: 8254976: Re-enable swing jtreg tests which were broken due to samevm mode
  • 6acfa07: 8244557: test/jdk/javax/swing/JTabbedPane/TestBackgroundScrollPolicy.java failed
  • 1ff1f0c: 8172269: When checking the default behaviour for a scroll tab layout and checking the 'opaque' checkbox, the area behind tabs is not red.
  • 7b3b204: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative
  • fb364db: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 8fadf3d: 8292158: AES-CTR cipher state corruption with AVX-512
  • 16a4bd3: 8288599: com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total swap size ... but getTotalSwapSpaceSize returned ...
  • 523ef55: 8282777: Create a Regression test for JDK-4515031
  • 957a888: 8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray
  • ... and 29 more: https://git.openjdk.org/jdk11u-dev/compare/9ddc8b02fa7632a3d4b8f24484a1ecbda3b247bc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2022
@openjdk openjdk bot closed this Oct 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2022
@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@GoeLin Pushed as commit bc2d8cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8285617 branch October 14, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants