Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8227651: Tests fail with SSLProtocolException: Input record too big #1448

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 12, 2022

I backport this for parity with 11.0.18-oracle.

I had to resolve the ProblemList, will mark as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8227651: Tests fail with SSLProtocolException: Input record too big
  • JDK-8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1448/head:pull/1448
$ git checkout pull/1448

Update a local copy of the PR:
$ git checkout pull/1448
$ git pull https://git.openjdk.org/jdk11u-dev pull/1448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1448

View PR using the GUI difftool:
$ git pr show -t 1448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1448.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7b029ea6ba1d44d361fdf980816732d8454b8194 8227651: Tests fail with SSLProtocolException: Input record too big Oct 12, 2022
@openjdk
Copy link

openjdk bot commented Oct 12, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8227651: Tests fail with SSLProtocolException: Input record too big
8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2022

Webrevs

@openjdk-notifier
Copy link

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@GoeLin GoeLin closed this Oct 13, 2022
@GoeLin GoeLin reopened this Oct 13, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Oct 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 16, 2022

Going to push as commit e8b7e77.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 9b7f3f9: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
  • 192179e: 8169187: [macosx] Aqua: java/awt/image/multiresolution/MultiresolutionIconTest.java
  • 7655988: 8284358: Unreachable loop is not removed from C2 IR, leading to a broken graph
  • 7a7b3df: 8286772: java/awt/dnd/DropTargetInInternalFrameTest/DropTargetInInternalFrameTest.html times out and fails in Windows
  • b77b0b5: 8285305: Create an automated test for JDK-4495286
  • bc2d8cc: 8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test
  • 243a55e: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368
  • 58ac929: 8254976: Re-enable swing jtreg tests which were broken due to samevm mode
  • 6acfa07: 8244557: test/jdk/javax/swing/JTabbedPane/TestBackgroundScrollPolicy.java failed
  • 1ff1f0c: 8172269: When checking the default behaviour for a scroll tab layout and checking the 'opaque' checkbox, the area behind tabs is not red.
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/16a4bd3dcc3da08f82af305a04d5fe8e2c126e5e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 16, 2022
@openjdk openjdk bot closed this Oct 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 16, 2022
@GoeLin GoeLin deleted the goetz_backport_8227651 branch October 16, 2022 18:07
@openjdk
Copy link

openjdk bot commented Oct 16, 2022

@GoeLin Pushed as commit e8b7e77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant