Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8172269: When checking the default behaviour for a scroll tab layout and checking the 'opaque' checkbox, the area behind tabs is not red. #1453

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 12, 2022

I backport this to fix an error in the tabbed pane.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8172269: When checking the default behaviour for a scroll tab layout and checking the 'opaque' checkbox, the area behind tabs is not red.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1453/head:pull/1453
$ git checkout pull/1453

Update a local copy of the PR:
$ git checkout pull/1453
$ git pull https://git.openjdk.org/jdk11u-dev pull/1453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1453

View PR using the GUI difftool:
$ git pr show -t 1453

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1453.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport eb91535be50d1c9882ec7a724dd247ece67a8266 8172269: When checking the default behaviour for a scroll tab layout and checking the 'opaque' checkbox, the area behind tabs is not red. Oct 12, 2022
@openjdk
Copy link

openjdk bot commented Oct 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8172269: When checking the default behaviour for a scroll tab layout and checking the 'opaque' checkbox, the area behind tabs is not red.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

Going to push as commit 1ff1f0c.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 7b3b204: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative
  • fb364db: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 8fadf3d: 8292158: AES-CTR cipher state corruption with AVX-512

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2022
@openjdk openjdk bot closed this Oct 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2022
@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@GoeLin Pushed as commit 1ff1f0c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8172269 branch October 14, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant