Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280158: New test from JDK-8274736 failed with/without patch in JDK11u #1465

Closed
wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 19, 2022

Fix as per suggestion of Daniel Jelinski, backport part of JDK-8211018


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280158: New test from JDK-8274736 failed with/without patch in JDK11u

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1465/head:pull/1465
$ git checkout pull/1465

Update a local copy of the PR:
$ git checkout pull/1465
$ git pull https://git.openjdk.org/jdk11u-dev pull/1465/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1465

View PR using the GUI difftool:
$ git pr show -t 1465

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1465.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

GHA issue unrelated.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@openjdk
Copy link

openjdk bot commented Oct 21, 2022

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8280158: New test from JDK-8274736 failed with/without patch in JDK11u

Reviewed-by: djelinski, stuefe, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 37d3bbd: 8295469: S390X: Optimized builds are broken
  • a2b2a22: 8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2022
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, snippet from JDK-8211018 looks good and the ProblemList entry matches 17u-dev, now.

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 29, 2022

Going to push as commit 18631ef.
Since your change was applied there have been 9 commits pushed to the master branch:

  • cb5e611: 8222251: preflow visitor is not visiting lambda expressions
  • 3c1e0cf: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS
  • d30cbeb: 8261336: IGV: enhance default filters
  • 19b9fde: 8228672: [TESTBUG] gc/metaspace/TestSizeTransitions.java fails on 32-bit platforms
  • 70ddb1b: 8295322: Tests for JDK-8271459 were not backported to 11u
  • 8608557: 8227179: Test for new gc+metaspace=info output format
  • 87853b0: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox
  • 37d3bbd: 8295469: S390X: Optimized builds are broken
  • a2b2a22: 8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 29, 2022
@openjdk openjdk bot closed this Oct 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2022
@openjdk
Copy link

openjdk bot commented Oct 29, 2022

@RealCLanger Pushed as commit 18631ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the 8280158 branch October 29, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
4 participants