8222251: preflow visitor is not visiting lambda expressions

[AntonKozlov]

Backport a regression fix after JDK-8203277

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8222251: preflow visitor is not visiting lambda expressions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1484/head:pull/1484
$ git checkout pull/1484

Update a local copy of the PR:
$ git checkout pull/1484
$ git pull https://git.openjdk.org/jdk11u-dev pull/1484/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1484

View PR using the GUI difftool:
$ git pr show -t 1484

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1484.diff

[bridgekeeper]

👋 Welcome back akozlov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@AntonKozlov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8222251: preflow visitor is not visiting lambda expressions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (94796502)

[AntonKozlov]

I'm investigating why macos tests have failed, but IMHO the failure is not related to the change but it looks like a network or configuration issue.

2022-10-27T12:56:21.2173950Z Launching JShell execution engine threw: FailOverExecutionControlProvider: FAILED: 0:jdi:hostname(127.0.0.1) --
2022-10-27T12:56:21.2174440Z   Exception: java.net.SocketTimeoutException: Accept timed out
2022-10-27T12:56:21.2174940Z                   java.base/java.net.PlainSocketImpl.socketAccept(Native Method)
2022-10-27T12:56:21.2175520Z                   java.base/java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:474)
2022-10-27T12:56:21.2175950Z                   java.base/java.net.ServerSocket.implAccept(ServerSocket.java:565)
2022-10-27T12:56:21.2178040Z                   java.base/java.net.ServerSocket.accept(ServerSocket.java:533)
2022-10-27T12:56:21.2178580Z                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:116)
2022-10-27T12:56:21.2179230Z FailOverExecutionControlProvider: FAILED: 1:jdi:launch(true) --
2022-10-27T12:56:21.2180650Z   Exception: java.lang.InternalError: Failed remote launch: java.util.concurrent.TimeoutException @ com.sun.jdi.CommandLineLaunch (defaults: home=/Users/runner/jdk-macos-x64/jdk-11.0.18-internal+0_macos-x64_bin/jdk-11.0.18.jdk/Contents/Home, options=, main=, suspend=true, quote=", vmexec=java) -- {home=home=/Users/runner/jdk-macos-x64/jdk-11.0.18-internal+0_macos-x64_bin/jdk-11.0.18.jdk/Contents/Home, options=options=, main=main=jdk.jshell.execution.RemoteExecutionControl 50519, suspend=suspend=true, quote=quote=", vmexec=vmexec=java}
2022-10-27T12:56:21.2184270Z                   jdk.jshell/jdk.jshell.execution.JdiInitiator.reportLaunchFail(JdiInitiator.java:300)
2022-10-27T12:56:21.2184790Z                   jdk.jshell/jdk.jshell.execution.JdiInitiator.launchTarget(JdiInitiator.java:141)
2022-10-27T12:56:21.2185210Z                   jdk.jshell/jdk.jshell.execution.JdiInitiator.<init>(JdiInitiator.java:110)
2022-10-27T12:56:21.2215400Z                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:103)
2022-10-27T12:56:21.2216290Z                   jdk.jshell/jdk.jshell.execution.JdiExecutionControlProvider.generate(JdiExecutionControlProvider.java:152)
2022-10-27T12:56:21.2217080Z       cause: java.util.concurrent.TimeoutException
2022-10-27T12:56:21.2217960Z FailOverExecutionControlProvider: FAILED: 2:jdi --
2022-10-27T12:56:21.2218680Z   Exception: java.net.SocketTimeoutException: Accept timed out
2022-10-27T12:56:21.2219090Z                   java.base/java.net.PlainSocketImpl.socketAccept(Native Method)
2022-10-27T12:56:21.2219520Z                   java.base/java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:474)
2022-10-27T12:56:21.2220350Z                   java.base/java.net.ServerSocket.implAccept(ServerSocket.java:565)
2022-10-27T12:56:21.2220750Z                   java.base/java.net.ServerSocket.accept(ServerSocket.java:533)
2022-10-27T12:56:21.2467440Z                   jdk.jshell/jdk.jshell.execution.JdiDefaultExecutionControl.create(JdiDefaultExecutionControl.java:116)
2022-10-27T12:56:21.2468110Z
2022-10-27T12:56:21.2468240Z java.lang.Exception: failures: 1
2022-10-27T12:56:21.2480360Z    at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:96)
2022-10-27T12:56:21.2480940Z    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2022-10-27T12:56:21.2481450Z    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2022-10-27T12:56:21.2482010Z    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2022-10-27T12:56:21.2482460Z    at java.base/java.lang.reflect.Method.invoke(Method.java:566)
2022-10-27T12:56:21.2483120Z    at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312)
2022-10-27T12:56:21.2483760Z    at java.base/java.lang.Thread.run(Thread.java:829)
2022-10-27T12:56:21.2484170Z
2022-10-27T12:56:21.2484330Z JavaTest Message: Test threw exception: java.lang.Exception
2022-10-27T12:56:21.2484610Z JavaTest Message: shutting down test
2022-10-27T12:56:21.2484760Z
2022-10-27T12:56:21.2485040Z STDOUT:
2022-10-27T12:56:21.2485280Z config KullaTesting.setUp(): success
2022-10-27T12:56:21.2485820Z test CustomInputToolBuilder.checkCustomInput(): failure
2022-10-27T12:56:21.2486130Z java.lang.AssertionError: actual:

[AntonKozlov]

All tests passed after re-run https://github.com/AntonKozlov/jdk11u-dev/actions/runs/3339702994

[AntonKozlov]

/integrate

[openjdk]

@AntonKozlov
Your change (at version 9479650) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit cb5e611.

[openjdk]

@yan-too @AntonKozlov Pushed as commit cb5e611.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.