Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails #1516

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 11, 2022

I backport this for parity with 11.0.19-oracle.

I had to replace a """ """ quoted string with java 11 syntax.

This is only a change to a test, and the edit is most trivial, therefore I'll mark this as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1516/head:pull/1516
$ git checkout pull/1516

Update a local copy of the PR:
$ git checkout pull/1516
$ git pull https://git.openjdk.org/jdk11u-dev pull/1516/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1516

View PR using the GUI difftool:
$ git pr show -t 1516

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1516.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f399ae558eabdce8960d339ef0758c023aeb89cc 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails Nov 11, 2022
@openjdk
Copy link

openjdk bot commented Nov 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 11, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Nov 11, 2022

/clean

@openjdk openjdk bot added the clean label Nov 11, 2022
@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 11, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 11, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Nov 15, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

Going to push as commit f2f7be9.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 8a40a9c: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java
  • 7e0603f: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java
  • 5d28a71: 8295714: GHA ::set-output is deprecated and will be removed
  • d2af653: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 15, 2022
@openjdk openjdk bot closed this Nov 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@GoeLin Pushed as commit f2f7be9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8202836 branch November 15, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant