Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment #1537

Closed
wants to merge 1 commit into from
Closed

8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment #1537

wants to merge 1 commit into from
+8 −5

Conversation

parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Nov 21, 2022 •
edited by openjdk bot
Loading

Backports a fix to ensure that ASGCT does not obtain the mentioned lock. Tested with my profiling tester.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1537/head:pull/1537
$ git checkout pull/1537

Update a local copy of the PR:
$ git checkout pull/1537
$ git pull https://git.openjdk.org/jdk11u-dev pull/1537/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1537

View PR using the GUI difftool:
$ git pr show -t 1537

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1537.diff

Sorry, something went wrong.

@parttimenerd parttimenerd changed the title Baclport 8285794 Backport 8285794 Nov 21, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2022

👋 Welcome back parttimenerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8285794 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 21, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2022

Webrevs

phohensee
phohensee approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Nov 28, 2022

@parttimenerd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • b5555c1: 8280863: Update build README to reflect that MSYS2 is supported
  • 178b400: 8295952: Problemlist existing compiler/rtm tests also on x86
  • bc704da: 8268860: Windows-Aarch64 build is failing in GitHub actions
  • af27be3: 8287724: Fix various issues with msys2
  • 99b722d: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails
  • 7f440c2: 8259485: Document need for short paths when building on Windows
  • 40f4fc2: 8257679: Improved unix compatibility layer in Windows build (winenv)
  • 382ac6b: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
  • c488e04: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
  • 597a800: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)"
  • ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/5d9c09b8f10da495989918cb64ea4f92f520ccb5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 28, 2022
@parttimenerd
Copy link
Contributor Author

/integrate

@jbachorik
Copy link
Contributor

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@parttimenerd
Your change (at version 7554e1c) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Nov 30, 2022

Going to push as commit 13bcc23.
Since your change was applied there have been 17 commits pushed to the master branch:

  • b5555c1: 8280863: Update build README to reflect that MSYS2 is supported
  • 178b400: 8295952: Problemlist existing compiler/rtm tests also on x86
  • bc704da: 8268860: Windows-Aarch64 build is failing in GitHub actions
  • af27be3: 8287724: Fix various issues with msys2
  • 99b722d: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails
  • 7f440c2: 8259485: Document need for short paths when building on Windows
  • 40f4fc2: 8257679: Improved unix compatibility layer in Windows build (winenv)
  • 382ac6b: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
  • c488e04: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
  • 597a800: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)"
  • ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/5d9c09b8f10da495989918cb64ea4f92f520ccb5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 30, 2022
@openjdk openjdk bot closed this Nov 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@jbachorik @parttimenerd Pushed as commit 13bcc23.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@parttimenerd parttimenerd deleted the parttimenerd_8285794 branch November 30, 2022 17:17
@parttimenerd parttimenerd restored the parttimenerd_8285794 branch November 30, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phohensee phohensee

Assignees
No one assigned
Labels
backport integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@parttimenerd @jbachorik @phohensee