Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java #1546

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Nov 22, 2022

Backport for
JDK-8297153 sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again
JDK-8297241 Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java

Original commit: openjdk/jdk@3c09498

Clean backport.
Fixing unstable test.
Checked on mac and linux by running:
make run-test TEST="test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java"


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
  • JDK-8297153: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1546/head:pull/1546
$ git checkout pull/1546

Update a local copy of the PR:
$ git checkout pull/1546
$ git pull https://git.openjdk.org/jdk11u-dev pull/1546/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1546

View PR using the GUI difftool:
$ git pr show -t 1546

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1546.diff

…enRenderingResizeTest.java

8297153: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again

Reviewed-by: serb
(cherry picked from commit 3c0949824e06f2b3d44f1bde9d2292a7627b0197)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3c0949824e06f2b3d44f1bde9d2292a7627b0197 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
8297153: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails again

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2022

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 24, 2022
@openjdk
Copy link

openjdk bot commented Nov 24, 2022

@Rudometov
Your change (at version 84cf42b) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 24, 2022

Going to push as commit 382ac6b.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 24, 2022
@openjdk openjdk bot closed this Nov 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 24, 2022
@openjdk
Copy link

openjdk bot commented Nov 24, 2022

@phohensee @Rudometov Pushed as commit 382ac6b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the 8297153 branch January 20, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants