Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297656: AArch64: Enable AES/GCM Intrinsics #1555

Closed
wants to merge 1 commit into from

Conversation

theRealAph
Copy link
Contributor

@theRealAph theRealAph commented Nov 25, 2022

These have been in mainline for more than a year. Time to enable them.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1555/head:pull/1555
$ git checkout pull/1555

Update a local copy of the PR:
$ git checkout pull/1555
$ git pull https://git.openjdk.org/jdk11u-dev pull/1555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1555

View PR using the GUI difftool:
$ git pr show -t 1555

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1555.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2022

👋 Welcome back aph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 25, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2022

Webrevs

Copy link
Contributor

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@openjdk
Copy link

openjdk bot commented Nov 26, 2022

@theRealAph This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8297656: AArch64: Enable AES/GCM Intrinsics

Reviewed-by: adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • b5555c1: 8280863: Update build README to reflect that MSYS2 is supported

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 26, 2022
@theRealAph
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 2, 2022

Going to push as commit dbd378c.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 5fdb254: 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used
  • da9de48: 8296715: CLDR v42 update for tzdata 2022f
  • dcc318c: 8297481: Create a regression test for JDK-4424517
  • 0bf122c: 8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free
  • 31666ec: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2
  • f643709: 8296496: Overzealous check in sizecalc.h prevents large memory allocation
  • 09d50d9: 8222091: Javadoc does not handle package annotations correctly on package-info.java
  • 13bcc23: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment
  • b5555c1: 8280863: Update build README to reflect that MSYS2 is supported

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 2, 2022
@openjdk openjdk bot closed this Dec 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 2, 2022
@openjdk
Copy link

openjdk bot commented Dec 2, 2022

@theRealAph Pushed as commit dbd378c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants