Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287011: Improve container information #1577

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Dec 9, 2022

Backport 8287011; os_linux.cpp had to be adjusted manually , the other file patches went in cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1577/head:pull/1577
$ git checkout pull/1577

Update a local copy of the PR:
$ git checkout pull/1577
$ git pull https://git.openjdk.org/jdk11u-dev pull/1577/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1577

View PR using the GUI difftool:
$ git pr show -t 1577

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1577.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e60939850e5328b9c0f2002ac5ed7744375bf18b 8287011: Improve container information Dec 9, 2022
@openjdk
Copy link

openjdk bot commented Dec 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 9, 2022

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287011: Improve container information

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9197181: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2022

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

Going to push as commit 01f5a19.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 12eca2f: 8256126: Create implementation for NSAccessibilityImage protocol peer
  • b3c7b28: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation
  • 604dd4d: 8179317: [TESTBUG] rewrite runtime shell tests in java
  • 7d50d51: 8259267: Refactor LoaderLeak shell test as java test.
  • e5c800c: Merge
  • 6400cdc: 8258005: JDK build fails with incorrect fixpath script
  • 9197181: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 15, 2022
@openjdk openjdk bot closed this Dec 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@MBaesken Pushed as commit 01f5a19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant