Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261350: Create implementation for NSAccessibilityCheckBox protocol peer #1582

Closed
wants to merge 1 commit into from

Conversation

Autumn808
Copy link
Contributor

@Autumn808 Autumn808 commented Dec 9, 2022

JDK-8261350 Merge conflict in file java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.m had to changed initWithCapacity. One of a series of 28 https://bugs.openjdk.org/browse/JDK-8152350


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8261350: Create implementation for NSAccessibilityCheckBox protocol peer

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1582/head:pull/1582
$ git checkout pull/1582

Update a local copy of the PR:
$ git checkout pull/1582
$ git pull https://git.openjdk.org/jdk11u-dev pull/1582/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1582

View PR using the GUI difftool:
$ git pr show -t 1582

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1582.diff

(cherry picked from commit 2b00367)
Autumn808 <AutumnCapasso@gmail.com>
Signed-off-by: Autumn808 <AutumnCapasso@gmail.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2022

👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2b00367e1154feb2c05b84a11d62fb5750e46acf 8261350: Create implementation for NSAccessibilityCheckBox protocol peer Dec 9, 2022
@openjdk
Copy link

openjdk bot commented Dec 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 9, 2022
@Autumn808 Autumn808 marked this pull request as ready for review December 13, 2022 18:15
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2022

Webrevs

@Autumn808 Autumn808 closed this Jan 9, 2023
@Autumn808 Autumn808 deleted the JDK-8261350 branch January 9, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant