Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8179317: [TESTBUG] rewrite runtime shell tests in java #1587

Closed
wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Dec 12, 2022

This is a backport of JDK-8179317 and also includes the fix JDK-8247741. Backporting this test fix is a prerequisite for #1554.

I had to resolve a few places. Also, test/hotspot/jtreg/runtime/TLS/testtls.sh is not part of jdk11u-dev, so I skipped it.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8179317: [TESTBUG] rewrite runtime shell tests in java
  • JDK-8247741: Test test/hotspot/jtreg/runtime/7162488/TestUnrecognizedVmOption.java fails when -XX:+IgnoreUnrecognizedVMOptions is set

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1587/head:pull/1587
$ git checkout pull/1587

Update a local copy of the PR:
$ git checkout pull/1587
$ git pull https://git.openjdk.org/jdk11u-dev pull/1587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1587

View PR using the GUI difftool:
$ git pr show -t 1587

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1587.diff

Converted shell tests to Java

Reviewed-by: dholmes, iignatyev, lmesnik
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ccb4ab5499275888e6a088d8bec2faccd6b4db28 8179317: [TESTBUG] rewrite runtime shell tests in java Dec 12, 2022
@openjdk
Copy link

openjdk bot commented Dec 12, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 12, 2022
@RealCLanger
Copy link
Contributor Author

/issue add 8247741

@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@RealCLanger
Adding additional issue to issue list: 8247741: Test test/hotspot/jtreg/runtime/7162488/TestUnrecognizedVmOption.java fails when -XX:+IgnoreUnrecognizedVMOptions is set.

@mlbridge
Copy link

mlbridge bot commented Dec 12, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Backport looks reasonable.

@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8179317: [TESTBUG] rewrite runtime shell tests in java
8247741: Test  test/hotspot/jtreg/runtime/7162488/TestUnrecognizedVmOption.java fails when -XX:+IgnoreUnrecognizedVMOptions is set

Converted shell tests to Java

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9197181: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2022
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

Going to push as commit 604dd4d.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 7d50d51: 8259267: Refactor LoaderLeak shell test as java test.
  • e5c800c: Merge
  • 6400cdc: 8258005: JDK build fails with incorrect fixpath script
  • 9197181: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 14, 2022
@openjdk openjdk bot closed this Dec 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@RealCLanger Pushed as commit 604dd4d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the JDK-8179317 branch December 14, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants