New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8179317: [TESTBUG] rewrite runtime shell tests in java #1587
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue and summary from the original commit. |
/issue add 8247741 |
@RealCLanger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. Backport looks reasonable.
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 604dd4d.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 604dd4d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a backport of JDK-8179317 and also includes the fix JDK-8247741. Backporting this test fix is a prerequisite for #1554.
I had to resolve a few places. Also, test/hotspot/jtreg/runtime/TLS/testtls.sh is not part of jdk11u-dev, so I skipped it.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1587/head:pull/1587
$ git checkout pull/1587
Update a local copy of the PR:
$ git checkout pull/1587
$ git pull https://git.openjdk.org/jdk11u-dev pull/1587/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1587
View PR using the GUI difftool:
$ git pr show -t 1587
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1587.diff