Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298737: 8296772 backport to jdk11u caused build error on sparc #1594

Closed
wants to merge 1 commit into from

Conversation

voitylov
Copy link

@voitylov voitylov commented Dec 14, 2022

This PR fixes a build regression on Solaris Sparc caused by JDK-8296772


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298737: 8296772 backport to jdk11u caused build error on sparc

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1594/head:pull/1594
$ git checkout pull/1594

Update a local copy of the PR:
$ git checkout pull/1594
$ git pull https://git.openjdk.org/jdk11u-dev pull/1594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1594

View PR using the GUI difftool:
$ git pr show -t 1594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1594.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2022

👋 Welcome back avoitylov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@voitylov voitylov changed the title JDK-8298737 8298737: 8296772 backport to jdk11u caused build error on sparc Dec 14, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 14, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Dec 14, 2022

Hi @voitylov
can you please redo this against jdk11u? As the bug is there too,
we should fix it in jdk11u. You need to flag jdk11u-critical-request. I'll grant it if the
change passes tests (which it will).
Thanks, Goetz.

@voitylov
Copy link
Author

Yep. Done.

@GoeLin
Copy link
Member

GoeLin commented Dec 14, 2022

Please close this PR.
The change will automatically be integrated to jdk11u-dev from jdk11u next Wednesday.
Thanks.

@voitylov
Copy link
Author

Closing as the PR is being integrated into jdk11u.

@voitylov voitylov closed this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
2 participants