Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8238936: The crash in XRobotPeer when the custom GraphicsDevice is used #1601

Closed
wants to merge 2 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 18, 2022

Hi all,
This pull request contains a backport of commit openjdk/jdk@9d0a487 from the openjdk/jdk repository.

Backport is clean, but I had to change the dates and imports. The new test is passed after the fix, and no new issues were found by the jdk_desktop tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8238936: The crash in XRobotPeer when the custom GraphicsDevice is used

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1601/head:pull/1601
$ git checkout pull/1601

Update a local copy of the PR:
$ git checkout pull/1601
$ git pull https://git.openjdk.org/jdk11u-dev pull/1601/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1601

View PR using the GUI difftool:
$ git pr show -t 1601

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1601.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9d0a4875d75421e416747271e3f229d068cf0dd0 8238936: The crash in XRobotPeer when the custom GraphicsDevice is used Dec 18, 2022
@openjdk
Copy link

openjdk bot commented Dec 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 18, 2022
@mrserb mrserb marked this pull request as ready for review December 19, 2022 08:13
@mrserb
Copy link
Member Author

mrserb commented Dec 19, 2022

/clean

@openjdk openjdk bot added the clean label Dec 19, 2022
@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8238936: The crash in XRobotPeer when the custom GraphicsDevice is used

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 19, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Dec 20, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 20, 2022

Going to push as commit dba3022.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 20, 2022
@openjdk openjdk bot closed this Dec 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@mrserb Pushed as commit dba3022.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the mrserb-backport-9d0a4875 branch December 20, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant